Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:45073 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756066Ab3ANUPU (ORCPT ); Mon, 14 Jan 2013 15:15:20 -0500 Date: Mon, 14 Jan 2013 15:04:17 -0500 From: "John W. Linville" To: Dan Carpenter Cc: Stefano Brivio , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] b43: N-PHY: fix gain in b43_nphy_get_gain_ctl_workaround_ent() Message-ID: <20130114200417.GC12018@tuxdriver.com> (sfid-20130114_211525_309552_7987314D) References: <20130113200309.GB5907@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20130113200309.GB5907@elgon.mountain> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun, Jan 13, 2013 at 11:03:09PM +0300, Dan Carpenter wrote: > There were no break statements in this switch statement so everything > used the default settings. > > Signed-off-by: Dan Carpenter > --- > Static checker stuff. Untested. > > diff --git a/drivers/net/wireless/b43/tables_nphy.c b/drivers/net/wireless/b43/tables_nphy.c > index 97d4e27..6a1c838 100644 > --- a/drivers/net/wireless/b43/tables_nphy.c > +++ b/drivers/net/wireless/b43/tables_nphy.c > @@ -3259,20 +3259,28 @@ struct nphy_gain_ctl_workaround_entry *b43_nphy_get_gain_ctl_workaround_ent( > switch (tr_iso) { > case 0: > e->cliplo_gain = 0x0062; > + break; > case 1: > e->cliplo_gain = 0x0064; > + break; > case 2: > e->cliplo_gain = 0x006a; > + break; > case 3: > e->cliplo_gain = 0x106a; > + break; > case 4: > e->cliplo_gain = 0x106c; > + break; > case 5: > e->cliplo_gain = 0x1074; > + break; > case 6: > e->cliplo_gain = 0x107c; > + break; > case 7: > e->cliplo_gain = 0x207c; > + break; > default: > e->cliplo_gain = 0x106a; > } Wow...nice find! This seems like it could be significant. Any comments from the b43 folks? Should this go to 3.8? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.