Return-path: Received: from mail-we0-f177.google.com ([74.125.82.177]:33203 "EHLO mail-we0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751111Ab3ARIv2 (ORCPT ); Fri, 18 Jan 2013 03:51:28 -0500 Received: by mail-we0-f177.google.com with SMTP id x48so721595wey.22 for ; Fri, 18 Jan 2013 00:51:27 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <13A1CEB6-9E61-4F02-A273-5F45F40A5D2C@gmail.com> References: <1358440472-26678-1-git-send-email-helmut.schaa@googlemail.com> <201301171816.15309.chunkeey@googlemail.com> <13A1CEB6-9E61-4F02-A273-5F45F40A5D2C@gmail.com> Date: Fri, 18 Jan 2013 09:51:27 +0100 Message-ID: (sfid-20130118_095133_588778_A99CCF2B) Subject: Re: [PATCH] rt2x00: Improve TX status handling for BlockAckReq frames From: Helmut Schaa To: Gertjan van Wingerde Cc: Christian Lamparter , "linville@tuxdriver.com" , "linux-wireless@vger.kernel.org" , "ivdoorn@gmail.com" , "stf_xl@wp.pl" , "andihartmann@01019freenet.de" , Stanislaw Gruszka Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jan 17, 2013 at 7:42 PM, Gertjan van Wingerde wrote: > On 17 jan. 2013, at 18:16, Christian Lamparter wrote: > >> On Thursday, January 17, 2013 05:34:32 PM Helmut Schaa wrote: >>> Since rt2800 hardware isn't capable of reporting the TX status of >>> BlockAckReq frames implement the TX status handling of BARs in >>> rt2x00lib. We keep track of all BARs that are send out and try to >>> match incoming BAs to the appropriate BARs. This allows us to report a >>> more or less accurate TX status for BAR frames which in turn improves >>> BA session stability. >> --- >> What about: >>> commit 5b632fe85ec82e5c43740b52e74c66df50a37db3 >>> Author: Stanislaw Gruszka >>> Date: Mon Dec 3 12:56:33 2012 +0100 >>> mac80211: introduce IEEE80211_HW_TEARDOWN_AGGR_ON_BAR_FAIL >> >> Should it be kept or dropped (as no driver uses it anymore?) > > I guess it should be dropped. I guess we could create a revert patch for that once this patch has been merged. Agreed, if it's unused now I'm in favor of reverting it. Helmut