Return-path: Received: from mail-ee0-f42.google.com ([74.125.83.42]:54591 "EHLO mail-ee0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755880Ab3AXVGw convert rfc822-to-8bit (ORCPT ); Thu, 24 Jan 2013 16:06:52 -0500 Received: by mail-ee0-f42.google.com with SMTP id b47so4792506eek.15 for ; Thu, 24 Jan 2013 13:06:51 -0800 (PST) References: <20130124205931.GB16252@localhost.localdomain> <20130124210028.GA22800@localhost.localdomain> Mime-Version: 1.0 (1.0) In-Reply-To: <20130124210028.GA22800@localhost.localdomain> Content-Type: text/plain; charset=us-ascii Message-Id: (sfid-20130124_220656_555522_99081101) Cc: "John W. Linville" , Xose Vazquez Perez , "linux-wireless@vger.kernel.org" , "users@rt2x00.serialmonkey.com" From: Gertjan van Wingerde Subject: Re: [PATCH 2/4] rt2x00: remove NOTICE Date: Thu, 24 Jan 2013 22:06:48 +0100 To: Stanislaw Gruszka Sender: linux-wireless-owner@vger.kernel.org List-ID: Sent from my iPad On 24 jan. 2013, at 22:00, Stanislaw Gruszka wrote: > We use this macro only on 3 places - remove it and replace by other > appropriate macros for printing messages. > > Signed-off-by: Stanislaw Gruszka Acked-by: Gertjan van Wingerde > --- > drivers/net/wireless/rt2x00/rt2800lib.c | 2 +- > drivers/net/wireless/rt2x00/rt2x00.h | 2 -- > drivers/net/wireless/rt2x00/rt2x00dev.c | 4 ++-- > 3 files changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c > index a1de95e..1791260 100644 > --- a/drivers/net/wireless/rt2x00/rt2800lib.c > +++ b/drivers/net/wireless/rt2x00/rt2800lib.c > @@ -80,7 +80,7 @@ static inline bool rt2800_is_305x_soc(struct rt2x00_dev *rt2x00dev) > rt2x00_rf(rt2x00dev, RF3022)) > return true; > > - NOTICE(rt2x00dev, "Unknown RF chipset on rt305x\n"); > + INFO(rt2x00dev, "Unknown RF chipset on rt305x\n"); > return false; > } > > diff --git a/drivers/net/wireless/rt2x00/rt2x00.h b/drivers/net/wireless/rt2x00/rt2x00.h > index 8ef11b6..ad73942 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00.h > +++ b/drivers/net/wireless/rt2x00/rt2x00.h > @@ -89,8 +89,6 @@ > DEBUG_PRINTK_PROBE(KERN_ERR, "Error", __msg, ##__args) > #define WARNING(__dev, __msg, __args...) \ > DEBUG_PRINTK_MSG(__dev, KERN_WARNING, "Warning", __msg, ##__args) > -#define NOTICE(__dev, __msg, __args...) \ > - DEBUG_PRINTK_MSG(__dev, KERN_NOTICE, "Notice", __msg, ##__args) > #define INFO(__dev, __msg, __args...) \ > DEBUG_PRINTK_MSG(__dev, KERN_INFO, "Info", __msg, ##__args) > #define DEBUG(__dev, __msg, __args...) \ > diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c > index 96fffe8..07a9e10 100644 > --- a/drivers/net/wireless/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c > @@ -1440,7 +1440,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev); > #ifdef CONFIG_PM > int rt2x00lib_suspend(struct rt2x00_dev *rt2x00dev, pm_message_t state) > { > - NOTICE(rt2x00dev, "Going to sleep.\n"); > + DEBUG(rt2x00dev, "Going to sleep.\n"); > > /* > * Prevent mac80211 from accessing driver while suspended. > @@ -1480,7 +1480,7 @@ EXPORT_SYMBOL_GPL(rt2x00lib_suspend); > > int rt2x00lib_resume(struct rt2x00_dev *rt2x00dev) > { > - NOTICE(rt2x00dev, "Waking up.\n"); > + DEBUG(rt2x00dev, "Waking up.\n"); > > /* > * Restore/enable extra components. > -- > 1.7.4.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html