Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:50246 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756955Ab3AYMIs (ORCPT ); Fri, 25 Jan 2013 07:08:48 -0500 Received: by mail-wg0-f45.google.com with SMTP id dq12so190710wgb.12 for ; Fri, 25 Jan 2013 04:08:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20121211100419.GA7822@earthship.arig> Date: Fri, 25 Jan 2013 13:08:46 +0100 Message-ID: (sfid-20130125_130851_753333_AF51F1C5) Subject: Re: [PATCH 3/3] rt2x00: add platform_data mac address From: Helmut Schaa To: Gertjan van Wingerde Cc: Daniel Golle , "" , "" , "" , "" , "" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On Tue, Dec 11, 2012 at 10:51 PM, Gertjan van Wingerde wrote: > And for this patch I have the same question as for the previous patch: why do we need to arrange this via platform data, > as opposed to using the standard user space ifconfig facility to set a mac address? This looks fine to me. I'd also prefer to pass in a MAC address from the platform data on SoC devices instead of having to write some user space code. And this is how it is done by other drivers as well. > As a second question: why is this only implemented for rt61pci, and not the other PCI / SOC drivers? Good point. Helmut