Return-path: Received: from na3sys009aog135.obsmtp.com ([74.125.149.84]:50920 "EHLO na3sys009aog135.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884Ab3BUCBP (ORCPT ); Wed, 20 Feb 2013 21:01:15 -0500 From: Bing Zhao To: Lubomir Rintel CC: Harro Haan , Dan Williams , "libertas-dev@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "John W. Linville" , "linux-kernel@vger.kernel.org" Date: Wed, 20 Feb 2013 17:59:43 -0800 Subject: RE: [PATCH] libertas sdio: remove CMD_FUNC_INIT call Message-ID: <477F20668A386D41ADCC57781B1F70430D9D6CEA08@SC-VEXCH1.marvell.com> (sfid-20130221_030138_891318_896EE7FF) References: <1358493883-28433-1-git-send-email-lkundrak@v3.sk> <477F20668A386D41ADCC57781B1F70430D140B07DE@SC-VEXCH1.marvell.com> <1361249203.14137.27.camel@unicorn.kokotovo> In-Reply-To: <1361249203.14137.27.camel@unicorn.kokotovo> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: SGkgTHVib21pciwNCg0KPiA+ID4gQEAgLTgyNSwyMCArODI1LDYgQEAgc3RhdGljIHZvaWQgaWZf c2Rpb19maW5pc2hfcG93ZXJfb24oc3RydWN0IGlmX3NkaW9fY2FyZCAqY2FyZCkNCj4gPiA+DQo+ ID4gPiAgCXNkaW9fcmVsZWFzZV9ob3N0KGZ1bmMpOw0KPiA+ID4NCj4gPiA+IC0JLyoNCj4gPiA+ IC0JICogRlVOQ19JTklUIGlzIHJlcXVpcmVkIGZvciBTRDg2ODggV0xBTi9CVCBtdWx0aXBsZSBm dW5jdGlvbnMNCj4gPiA+IC0JICovDQo+ID4gPiAtCWlmIChjYXJkLT5tb2RlbCA9PSBNT0RFTF84 Njg4KSB7DQo+ID4gPiAtCQlzdHJ1Y3QgY21kX2hlYWRlciBjbWQ7DQo+ID4gPiAtDQo+ID4gPiAt CQltZW1zZXQoJmNtZCwgMCwgc2l6ZW9mKGNtZCkpOw0KPiA+ID4gLQ0KPiA+ID4gLQkJbGJzX2Rl Yl9zZGlvKCJzZW5kIGZ1bmN0aW9uIElOSVQgY29tbWFuZFxuIik7DQo+ID4gPiAtCQlpZiAoX19s YnNfY21kKHByaXYsIENNRF9GVU5DX0lOSVQsICZjbWQsIHNpemVvZihjbWQpLA0KPiA+ID4gLQkJ CQlsYnNfY21kX2NvcHliYWNrLCAodW5zaWduZWQgbG9uZykgJmNtZCkpDQo+ID4gPiAtCQkJbmV0 ZGV2X2FsZXJ0KHByaXYtPmRldiwgIkNNRF9GVU5DX0lOSVQgY21kIGZhaWxlZFxuIik7DQo+ID4g PiAtCX0NCj4gPiA+IC0NCj4gPg0KPiA+IFJlbW92aW5nIEZVTkNfSU5JVCBjb3VsZCBicmVhayB0 aGluZ3MgaW4gc29tZSBzY2VuYXJpb3MuDQo+ID4gQ291bGQgeW91IHBsZWFzZSB0ZXN0IHRoZSBm b2xsb3dpbmcgY2FzZT8NCj4gPg0KPiA+IDEuIGluc21vZCBsaWJlcmF0ZXMgLT4gZG93bmxvYWQg ZmlybXdhcmUsIHNlbmQgRlVOQ19JTklULCAuLi4NCj4gPiAyLiBybW1vZCBsaWJlcnRhcyAtPiBz ZW5kIEZVTkNfU0hVVERPV04gY29tbWFuZCB0byBmaXJtd2FyZTsgQlQgaXMgc3RpbGwgd29ya2lu Zy4NCj4gPiAzLiBpbnNtb2QgbGliZXJ0YXMgLT4gc2tpcCBmaXJtd2FyZSBkb3dubG9hZGluZywg c2VuZCBGVU5DX0lOSVQsIC4uLg0KPiA+DQo+ID4gSWYgRlVOQ19JTklUIGlzIHJlbW92ZWQsIEkg ZG9uJ3QgZXhwZWN0IHN0ZXAgMyB0byB3b3JrLg0KPiANCj4gSW4gY2FzZSBidG1ydmxfc2RpbyBp cyBsb2FkZWQsIHRoZSBkcml2ZXIgYWx3YXlzIGxvY2tzIHVwIGluIEZVTkNfSU5JVA0KPiB1cG9u IHByb2JlIHRpbWUsIHRodXMgSSdtIG5vdCBhYmxlIHRvIHByb2NlZWQgdG8gZnVydGhlciBzdGVw cy4NCj4gDQo+IFsgIDIwOS4zMzg5NTNdIFs8YzA1MDIyNDg+XSAoX19zY2hlZHVsZSsweDYxMC8w eDc2NCkgZnJvbSBbPGJmMjBhZTI0Pl0gKF9fbGJzX2NtZCsweGI4LzB4MTMwDQo+IFtsaWJlcnRh c10pDQo+IFsgIDIwOS4zNDgzNDBdIFs8YmYyMGFlMjQ+XSAoX19sYnNfY21kKzB4YjgvMHgxMzAg W2xpYmVydGFzXSkgZnJvbSBbPGJmMjIyNDc0Pl0NCj4gKGlmX3NkaW9fZmluaXNoX3Bvd2VyX29u KzB4ZWMvMHgxYjAgW2xpYmVydGFzX3NkaW9dKQ0KPiBbICAyMDkuMzYwMTM2XSBbPGJmMjIyNDc0 Pl0gKGlmX3NkaW9fZmluaXNoX3Bvd2VyX29uKzB4ZWMvMHgxYjAgW2xpYmVydGFzX3NkaW9dKSBm cm9tIFs8YmYyMjI2YzQ+XQ0KPiAoaWZfc2Rpb19wb3dlcl9vbisweDE4Yy8weDIwYyBbbGliZXJ0 YXNfc2Rpb10pDQo+IFsgIDIwOS4zNzMwNTJdIFs8YmYyMjI2YzQ+XSAoaWZfc2Rpb19wb3dlcl9v bisweDE4Yy8weDIwYyBbbGliZXJ0YXNfc2Rpb10pIGZyb20gWzxiZjIyMjk0ND5dDQo+IChpZl9z ZGlvX3Byb2JlKzB4MjAwLzB4MzFjIFtsaWJlcnRhc19zZGlvXSkNCj4gWyAgMjA5LjM4NTMxNl0g WzxiZjIyMjk0ND5dIChpZl9zZGlvX3Byb2JlKzB4MjAwLzB4MzFjIFtsaWJlcnRhc19zZGlvXSkg ZnJvbSBbPGJmMDFkODIwPl0NCj4gKHNkaW9fYnVzX3Byb2JlKzB4OTQvMHhmYyBbbW1jX2NvcmVd KQ0KPiBbICAyMDkuMzk2NzQ4XSBbPGJmMDFkODIwPl0gKHNkaW9fYnVzX3Byb2JlKzB4OTQvMHhm YyBbbW1jX2NvcmVdKSBmcm9tIFs8YzAyZTcyOWM+XQ0KPiAoZHJpdmVyX3Byb2JlX2RldmljZSsw eDEyYy8weDM0OCkNCj4gWyAgMjA5LjQwNzIxNF0gWzxjMDJlNzI5Yz5dIChkcml2ZXJfcHJvYmVf ZGV2aWNlKzB4MTJjLzB4MzQ4KSBmcm9tIFs8YzAyZTc1MzA+XQ0KPiAoX19kcml2ZXJfYXR0YWNo KzB4NzgvMHg5YykNCj4gWyAgMjA5LjQxNjc5OF0gWzxjMDJlNzUzMD5dIChfX2RyaXZlcl9hdHRh Y2grMHg3OC8weDljKSBmcm9tIFs8YzAyZTU2NTg+XSAoYnVzX2Zvcl9lYWNoX2RldisweDUwLzB4 ODgpDQo+IFsgIDIwOS40MjU5NDZdIFs8YzAyZTU2NTg+XSAoYnVzX2Zvcl9lYWNoX2RldisweDUw LzB4ODgpIGZyb20gWzxjMDJlNjgxMD5dDQo+IChidXNfYWRkX2RyaXZlcisweDEwOC8weDI2OCkN Cj4gWyAgMjA5LjQzNTE4MF0gWzxjMDJlNjgxMD5dIChidXNfYWRkX2RyaXZlcisweDEwOC8weDI2 OCkgZnJvbSBbPGMwMmU3ODJjPl0NCj4gKGRyaXZlcl9yZWdpc3RlcisweGE0LzB4MTM0KQ0KPiBb ICAyMDkuNDQ0NDI2XSBbPGMwMmU3ODJjPl0gKGRyaXZlcl9yZWdpc3RlcisweGE0LzB4MTM0KSBm cm9tIFs8YmYyMjYwMWM+XQ0KPiAoaWZfc2Rpb19pbml0X21vZHVsZSsweDFjLzB4M2MgW2xpYmVy dGFzX3NkaW9dKQ0KPiBbICAyMDkuNDU1MzM5XSBbPGJmMjI2MDFjPl0gKGlmX3NkaW9faW5pdF9t b2R1bGUrMHgxYy8weDNjIFtsaWJlcnRhc19zZGlvXSkgZnJvbSBbPGMwMDA4NWI4Pl0NCj4gKGRv X29uZV9pbml0Y2FsbCsweDk4LzB4MTc0KQ0KPiBbICAyMDkuNDY2MjM2XSBbPGMwMDA4NWI4Pl0g KGRvX29uZV9pbml0Y2FsbCsweDk4LzB4MTc0KSBmcm9tIFs8YzAwNzY1MDQ+XSAobG9hZF9tb2R1 bGUrMHgxYzVjLzB4MWY4MCkNCj4gWyAgMjA5LjQ3NTM5MF0gWzxjMDA3NjUwND5dIChsb2FkX21v ZHVsZSsweDFjNWMvMHgxZjgwKSBmcm9tIFs8YzAwNzY5MmM+XQ0KPiAoc3lzX2luaXRfbW9kdWxl KzB4MTA0LzB4MTI4KQ0KPiBbICAyMDkuNDg0NjMyXSBbPGMwMDc2OTJjPl0gKHN5c19pbml0X21v ZHVsZSsweDEwNC8weDEyOCkgZnJvbSBbPGMwMDA4YzQwPl0NCj4gKHJldF9mYXN0X3N5c2NhbGwr MHgwLzB4MzgpDQo+IA0KPiBJbiBjYXNlIGJ0bXJ2bF9zZGlvIGlzIF9ub3RfIGxvYWRlZCwgaW5z bW9kIHJldHVybnMsIGJ1dCBkcml2ZXIgbG9ja3MgdXANCj4gd2FpdGluZyBmb3IgRlVOQ19JTklU IHRvIGZpbmlzaDoNCj4gDQo+IFsgIDMwMC41Mzg4NTldIFs8YzA1MDIyNDg+XSAoX19zY2hlZHVs ZSsweDYxMC8weDc2NCkgZnJvbSBbPGJmMWZhZTI0Pl0gKF9fbGJzX2NtZCsweGI4LzB4MTMwDQo+ IFtsaWJlcnRhc10pDQo+IFsgIDMwMC41NDg2MDBdIFs8YmYxZmFlMjQ+XSAoX19sYnNfY21kKzB4 YjgvMHgxMzAgW2xpYmVydGFzXSkgZnJvbSBbPGJmMjEyNDc0Pl0NCj4gKGlmX3NkaW9fZmluaXNo X3Bvd2VyX29uKzB4ZWMvMHgxYjAgW2xpYmVydGFzX3NkaW9dKQ0KPiBbICAzMDAuNTYwMzk4XSBb PGJmMjEyNDc0Pl0gKGlmX3NkaW9fZmluaXNoX3Bvd2VyX29uKzB4ZWMvMHgxYjAgW2xpYmVydGFz X3NkaW9dKSBmcm9tIFs8YmYyMTMyMzA+XQ0KPiAoaWZfc2Rpb19kb19wcm9nX2Zpcm13YXJlKzB4 NDE0LzB4NDU0IFtsaWJlcnRhc19zZGlvXSkNCj4gWyAgMzAwLjU3NDA1Ml0gWzxiZjIxMzIzMD5d IChpZl9zZGlvX2RvX3Byb2dfZmlybXdhcmUrMHg0MTQvMHg0NTQgW2xpYmVydGFzX3NkaW9dKSBm cm9tIFs8YmYxZmZmYmM+XQ0KPiAobGJzX2Z3X2xvYWRlZCsweDI0LzB4NTggW2xpYmVydGFzXSkN Cj4gWyAgMzAwLjU4NjkwN10gWzxiZjFmZmZiYz5dIChsYnNfZndfbG9hZGVkKzB4MjQvMHg1OCBb bGliZXJ0YXNdKSBmcm9tIFs8YzAyZjAyYzA+XQ0KPiAocmVxdWVzdF9maXJtd2FyZV93b3JrX2Z1 bmMrMHhiMC8weGY0KQ0KPiBbICAzMDAuNTk3NzQ2XSBbPGMwMmYwMmMwPl0gKHJlcXVlc3RfZmly bXdhcmVfd29ya19mdW5jKzB4YjAvMHhmNCkgZnJvbSBbPGMwMDNhZTBjPl0NCj4gKHByb2Nlc3Nf b25lX3dvcmsrMHgzNDgvMHg2YTgpDQo+IFsgIDMwMC42MDgyODhdIFs8YzAwM2FlMGM+XSAocHJv Y2Vzc19vbmVfd29yaysweDM0OC8weDZhOCkgZnJvbSBbPGMwMDNiNDA4Pl0NCj4gKHdvcmtlcl90 aHJlYWQrMHgyNjgvMHgzOTApDQo+IFsgIDMwMC42MTc2MzBdIFs8YzAwM2I0MDg+XSAod29ya2Vy X3RocmVhZCsweDI2OC8weDM5MCkgZnJvbSBbPGMwMDQxNGIwPl0gKGt0aHJlYWQrMHhjMC8weGQ0 KQ0KPiBbICAzMDAuNjI1OTQ3XSBbPGMwMDQxNGIwPl0gKGt0aHJlYWQrMHhjMC8weGQ0KSBmcm9t IFs8YzAwMDhjZTg+XSAocmV0X2Zyb21fZm9yaysweDE0LzB4MjApDQo+IFsgIDMwMC42MzQxMzVd IDIgbG9ja3MgaGVsZCBieSBrd29ya2VyLzA6MS8xOToNCj4gWyAgMzAwLjYzODM4M10gICMwOiAg KGV2ZW50cyl7LisuKy4rfSwgYXQ6IFs8YzAwM2FjY2M+XSBwcm9jZXNzX29uZV93b3JrKzB4MjA4 LzB4NmE4DQo+IFsgIDMwMC42NDY1MTJdICAjMTogICgoJmZ3X3dvcmstPndvcmspKXsrLisuKy59 LCBhdDogWzxjMDAzYWNjYz5dIHByb2Nlc3Nfb25lX3dvcmsrMHgyMDgvMHg2YTgNCg0KVGhlcmUg c2VlbXMgdG8gYmUgYSByYWNlIGNvbmRpdGlvbiBpbiBsYnNfdGhyZWFkKCkuDQoNCkF0IGxpbmUg NTgyOg0KIDU4MiAgICAgICAgICAgICAgICAgaWYgKCFwcml2LT5md19yZWFkeSkNCiA1ODMgICAg ICAgICAgICAgICAgICAgICAgICAgY29udGludWU7DQoNClRoZSBmd19yZWFkeSBpcyAwLCBzbyB5 b3UgbmV2ZXIgZ2V0IHRoZSBjaGFuY2UgdG8gZXhlY3V0ZSB0aGUgRlVOQ19JTklUIGNvbW1hbmQu DQoNCiA2MTcgICAgICAgICAgICAgICAgIC8qIEV4ZWN1dGUgdGhlIG5leHQgY29tbWFuZCAqLw0K IDYxOCAgICAgICAgICAgICAgICAgaWYgKCFwcml2LT5kbmxkX3NlbnQgJiYgIXByaXYtPmN1cl9j bWQpDQogNjE5ICAgICAgICAgICAgICAgICAgICAgICAgIGxic19leGVjdXRlX25leHRfY29tbWFu ZChwcml2KTsNCg0KDQpDb3VsZCB5b3UgdHJ5IHRoZSBmb2xsb3dpbmcgY2hhbmdlPw0KDQpkaWZm IC0tZ2l0IGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbGliZXJ0YXMvaWZfc2Rpby5jIGIvZHJpdmVy cy9uZXQvd2lyZWxlc3MvbGliZQ0KaW5kZXggNzM5MzA5ZS4uOGY1ZDk3NyAxMDA2NDQNCi0tLSBh L2RyaXZlcnMvbmV0L3dpcmVsZXNzL2xpYmVydGFzL2lmX3NkaW8uYw0KKysrIGIvZHJpdmVycy9u ZXQvd2lyZWxlc3MvbGliZXJ0YXMvaWZfc2Rpby5jDQpAQCAtODI1LDYgKzgyNSw4IEBAIHN0YXRp YyB2b2lkIGlmX3NkaW9fZmluaXNoX3Bvd2VyX29uKHN0cnVjdCBpZl9zZGlvX2NhcmQgKmNhcg0K DQogICAgICAgIHNkaW9fcmVsZWFzZV9ob3N0KGZ1bmMpOw0KDQorICAgICAgIHByaXYtPmZ3X3Jl YWR5ID0gMTsNCisNCiAgICAgICAgLyoNCiAgICAgICAgICogRlVOQ19JTklUIGlzIHJlcXVpcmVk IGZvciBTRDg2ODggV0xBTi9CVCBtdWx0aXBsZSBmdW5jdGlvbnMNCiAgICAgICAgICovDQpAQCAt ODM5LDcgKzg0MSw2IEBAIHN0YXRpYyB2b2lkIGlmX3NkaW9fZmluaXNoX3Bvd2VyX29uKHN0cnVj dCBpZl9zZGlvX2NhcmQgKmNhcg0KICAgICAgICAgICAgICAgICAgICAgICAgbmV0ZGV2X2FsZXJ0 KHByaXYtPmRldiwgIkNNRF9GVU5DX0lOSVQgY21kIGZhaWxlZFxuIik7DQogICAgICAgIH0NCg0K LSAgICAgICBwcml2LT5md19yZWFkeSA9IDE7DQogICAgICAgIHdha2VfdXAoJmNhcmQtPnB3cm9u X3dhaXRxKTsNCg0KICAgICAgICBpZiAoIWNhcmQtPnN0YXJ0ZWQpIHsNCg0KVGhhbmtzLA0KQmlu Zw0KDQo+IA0KPiBJZiBJIHJlbW92ZSB0aGUgRlVOQ19JTklUIGNhbGwsIHdpZmkgd29ya3MgZmlu ZSwgYnV0IGJsdWV0b290aCBzdG9wcw0KPiB3b3JraW5nIGFmdGVyIGEgbmV0d29yayBzY2FuOg0K PiANCj4gW3Jvb3RAbWVnYWxvZG9uIGxrdW5kcmFrXSMgaXdsaXN0IHNjYW4gPi9kZXYvbnVsbCAy PiYxDQo+IFtyb290QG1lZ2Fsb2RvbiBsa3VuZHJha10jIGhjaXRvb2wgc2NhbiAtLWZsdXNoDQo+ IERldmljZSBpcyBub3QgYXZhaWxhYmxlOiBObyBzdWNoIGRldmljZQ0KPiBbcm9vdEBtZWdhbG9k b24gbGt1bmRyYWtdIw0K