Return-path: Received: from mail.candelatech.com ([208.74.158.172]:53925 "EHLO ns3.lanforge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754686Ab3BFR62 (ORCPT ); Wed, 6 Feb 2013 12:58:28 -0500 Message-ID: <511299BA.905@candelatech.com> (sfid-20130206_185833_803968_2A91EE34) Date: Wed, 06 Feb 2013 09:58:18 -0800 From: Ben Greear MIME-Version: 1.0 To: Cong Ding CC: Johannes Berg , "John W. Linville" , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: mac80211/cfg.c: fix error using of sizeof() References: <1360167826-29265-1-git-send-email-dinggnu@gmail.com> In-Reply-To: <1360167826-29265-1-git-send-email-dinggnu@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 02/06/2013 08:23 AM, Cong Ding wrote: > Using 'sizeof' on array given as function argument returns size of a pointer > rather than the size of array. > > Signed-off-by: Cong Ding > --- > net/mac80211/cfg.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c > index 661b878..af561d5 100644 > --- a/net/mac80211/cfg.c > +++ b/net/mac80211/cfg.c > @@ -2058,7 +2058,8 @@ static int ieee80211_set_mcast_rate(struct wiphy *wiphy, struct net_device *dev, > { > struct ieee80211_sub_if_data *sdata = IEEE80211_DEV_TO_SUB_IF(dev); > > - memcpy(sdata->vif.bss_conf.mcast_rate, rate, sizeof(rate)); > + memcpy(sdata->vif.bss_conf.mcast_rate, rate, > + sizeof(int) * IEEE80211_NUM_BANDS); Should it perhaps be: sizeof(*rate) * IEEE80211_NUM_BANDS just in case the type ever changes? Thanks, Ben > > return 0; > } > -- Ben Greear Candela Technologies Inc http://www.candelatech.com