Message-ID: <1360572417.8738.4.camel@jlt4.sipsolutions.net> (sfid-20130211_094709_796250_E8B71179)
Subject: Re: [RFC] mac80211: Add support for Tx-AMSDU viz debugfs.
From: Johannes Berg <johannes@sipsolutions.net>
To: Krishna Chaitanya <chaitanya.mgit@gmail.com>
Cc: Felix Fietkau <nbd@openwrt.org>, chaitanyatk@posedge.com,
	linux-wireless@vger.kernel.org, maheshp@posedge.com
Date: Mon, 11 Feb 2013 09:46:57 +0100
In-Reply-To: <CABPxzYLY5-MmePjUUGedC4rT88b328u7AKOeHREuF11BuOjYGA@mail.gmail.com> (sfid-20130211_085523_217176_1B4FC070)
References: <7384f4ddc838247a0f467708d66baa8c@posedge.com>
	 <1360225230.8038.1.camel@jlt4.sipsolutions.net>
	 <CABPxzYLnWjxtN_c1sFXpA3Ye9ZNvQgV1dU0z=59j0WqgM-rUpg@mail.gmail.com>
	 <1360228991.8038.3.camel@jlt4.sipsolutions.net>
	 <CABPxzYLwEfzwS9b8dAGjbqT2MLo9FdTKkRwWKDvzxp82ObB-9Q@mail.gmail.com>
	 <5113B42A.4020708@openwrt.org>
	 <1360246653.8038.9.camel@jlt4.sipsolutions.net>
	 <CABPxzYJG3xP0_Wy-1HMjWx-YoHp5WmhrfBH5vBvOJ4WQ_7Nzrg@mail.gmail.com>
	 <5113C5E0.5050509@openwrt.org>
	 <1360250827.8038.10.camel@jlt4.sipsolutions.net>
	 <CABPxzYLY5-MmePjUUGedC4rT88b328u7AKOeHREuF11BuOjYGA@mail.gmail.com>
	 (sfid-20130211_085523_217176_1B4FC070)
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Mon, 2013-02-11 at 13:24 +0530, Krishna Chaitanya wrote:
> On Thu, Feb 7, 2013 at 8:57 PM, Johannes Berg <johannes@sipsolutions.net> wrote:
> > On Thu, 2013-02-07 at 16:18 +0100, Felix Fietkau wrote:
> >
> >> > But whats the use of sending an AMSDU if we are not connected?
> >> > First check in the code is to check for a connection.
> >> I mentioned cooked monitor because putting the hw in monitor mode may
> >> not always be desirable, and cooked monitor bypasses that.
> >
> > You can pass "flags none" on the iw command line and it shouldn't change
> > much then, but yeah, still might do a few other things. Anyway cooked
> > should work fine.
> 
> Even in the cooked monitor case, the setting of qos_header is done
> in the ieee80211_xmit(), so we still need to have some flag to know
> if its an AMSDU/Not based, even if we set the bit in the user space
> this will overwrite that.

You should be able to patch this very easily to preserve the A-MSDU bit,
which won't matter in the normal case where it's always cleared.

johannes