Return-path: Received: from he.sipsolutions.net ([78.46.109.217]:43384 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506Ab3BDPkL (ORCPT ); Mon, 4 Feb 2013 10:40:11 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1U2O9S-00032G-3w for linux-wireless@vger.kernel.org; Mon, 04 Feb 2013 16:40:10 +0100 Message-ID: <1359992435.10311.19.camel@jlt4.sipsolutions.net> (sfid-20130204_164015_603432_7D6A9A79) Subject: Re: [PATCH] cfg80211: fix BSS list hidden SSID lookup From: Johannes Berg To: linux-wireless@vger.kernel.org Date: Mon, 04 Feb 2013 16:40:35 +0100 In-Reply-To: <1359742986-12932-1-git-send-email-johannes@sipsolutions.net> (sfid-20130201_192315_970791_397EE812) References: <1359742986-12932-1-git-send-email-johannes@sipsolutions.net> (sfid-20130201_192315_970791_397EE812) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 2013-02-01 at 19:23 +0100, Johannes Berg wrote: > From: Johannes Berg > > When trying to find a hidden SSID, the lookup function > is done wrong; the code is trying to combine the two > lookups into one, and as a consequence doesn't always > find the entry at all. To understand this, consider a > case where multiple BSS entries with the same channel > and BSSID exist but have different SSID length. Then > comparing against the probe response SSID length is > bound to cause problems since the hidden one might be > either zeroed out or zero-length. > > To fix this we need to do two lookups for the two ways > to hide SSIDs. Applied. johannes