Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:44342 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752972Ab3BDR6V (ORCPT ); Mon, 4 Feb 2013 12:58:21 -0500 Received: by mail-wi0-f179.google.com with SMTP id ez12so3270523wid.0 for ; Mon, 04 Feb 2013 09:58:20 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1359999522.17993.20.camel@jlt4.sipsolutions.net> References: <1359853341-29237-1-git-send-email-thomas@cozybit.com> <1359853341-29237-3-git-send-email-thomas@cozybit.com> <1359999522.17993.20.camel@jlt4.sipsolutions.net> From: Thomas Pedersen Date: Mon, 4 Feb 2013 09:57:58 -0800 Message-ID: (sfid-20130204_185824_691544_275A1B3F) Subject: Re: [PATCH 2/3] mac80211: generate mesh probe requests To: Johannes Berg Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Feb 4, 2013 at 9:38 AM, Johannes Berg wrote: > On Sat, 2013-02-02 at 17:02 -0800, Thomas Pedersen wrote: > >> - pos = skb_put(skb, ie_ssid_len); >> - *pos++ = WLAN_EID_SSID; >> + if (ieee80211_vif_is_mesh(vif)) { >> + pos = skb_put(skb, 2 + 2 + ssid_len); >> + *pos++ = WLAN_EID_SSID; >> + *pos++ = 0; >> + /* NOTE: mesh ID will be out of order */ > > Why put it out of order? > > Also I'm not convinced that it's a good idea to translate "SSID" from > the userspace API to "mesh ID" silently? Might make more sense to have > those separately maybe? I mean, it seems reasonable to even think you > might scan for a mesh network when you're not a mesh interface, for > example? Yeah that makes more sense, but will obviously require more work. I'll just drop this for now. -- Thomas