Return-path: Received: from mail-we0-f170.google.com ([74.125.82.170]:47199 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753167Ab3BKHzF (ORCPT ); Mon, 11 Feb 2013 02:55:05 -0500 Received: by mail-we0-f170.google.com with SMTP id z53so4702695wey.29 for ; Sun, 10 Feb 2013 23:55:03 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1360250827.8038.10.camel@jlt4.sipsolutions.net> References: <7384f4ddc838247a0f467708d66baa8c@posedge.com> <1360225230.8038.1.camel@jlt4.sipsolutions.net> <1360228991.8038.3.camel@jlt4.sipsolutions.net> <5113B42A.4020708@openwrt.org> <1360246653.8038.9.camel@jlt4.sipsolutions.net> <5113C5E0.5050509@openwrt.org> <1360250827.8038.10.camel@jlt4.sipsolutions.net> From: Krishna Chaitanya Date: Mon, 11 Feb 2013 13:24:42 +0530 Message-ID: (sfid-20130211_085517_681941_152A0488) Subject: Re: [RFC] mac80211: Add support for Tx-AMSDU viz debugfs. To: Johannes Berg Cc: Felix Fietkau , chaitanyatk@posedge.com, linux-wireless@vger.kernel.org, maheshp@posedge.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Feb 7, 2013 at 8:57 PM, Johannes Berg wrote: > On Thu, 2013-02-07 at 16:18 +0100, Felix Fietkau wrote: > >> > But whats the use of sending an AMSDU if we are not connected? >> > First check in the code is to check for a connection. >> I mentioned cooked monitor because putting the hw in monitor mode may >> not always be desirable, and cooked monitor bypasses that. > > You can pass "flags none" on the iw command line and it shouldn't change > much then, but yeah, still might do a few other things. Anyway cooked > should work fine. Even in the cooked monitor case, the setting of qos_header is done in the ieee80211_xmit(), so we still need to have some flag to know if its an AMSDU/Not based, even if we set the bit in the user space this will overwrite that.