MIME-Version: 1.0
Content-Type: text/plain;
	charset="Windows-1252"
Subject: RE: [PATCH] b43: Increase number of RX DMA slots
Date: Tue, 19 Feb 2013 09:42:28 -0000
Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6026B7152@saturn3.aculab.com> (sfid-20130219_104329_246750_978FD6CD)
In-Reply-To: <20130219.005206.397289032011003833.davem@davemloft.net>
References: <1361156480-32566-1-git-send-email-Larry.Finger@lwfinger.net> <20130219.005206.397289032011003833.davem@davemloft.net>
From: "David Laight" <David.Laight@ACULAB.COM>
To: "David Miller" <davem@davemloft.net>, <Larry.Finger@lwfinger.net>
Cc: <linville@tuxdriver.com>, <linux-wireless@vger.kernel.org>,
	<netdev@vger.kernel.org>, <bittorf@bluebottle.com>,
	<stable@vger.kernel.org>
Sender: linux-wireless-owner@vger.kernel.org

> > Bastian Bittorf reported that some of the silent freezes on a Linksys WRT54G
> > were due to overflow of the RX DMA ring buffer, which was created with 64
> > slots. That finding reminded me that I was seeing similar crashed on a netbook,
> > which also has a relatively slow processor. After increasing the number of
> > slots to 128, runs on the netbook that previously failed now worked; however,
> > I found that 109 slots had been used in one test. For that reason, the number
> > of slots is being increased to 256.

Surely the driver should work even if all the RX buffers get filled?
Increasing the number of buffers is just hiding the issue.
A burst of 300 back to back small packets probably fills the 256 slots.

I realise that dropping frames isn't ideal, and that small numbers
of buffers can make it impossible to receive long fragmented IP
messages. but increasing the number of buffers doesn't seem to
be the best fix for a 'silent freeze'.

It might be that the driver would be more robust if it only ever
put rx buffers into all but one of the ring slots.

	David