Return-path: Received: from mail-oa0-f46.google.com ([209.85.219.46]:50945 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278Ab3CGQlQ convert rfc822-to-8bit (ORCPT ); Thu, 7 Mar 2013 11:41:16 -0500 Received: by mail-oa0-f46.google.com with SMTP id k1so829628oag.33 for ; Thu, 07 Mar 2013 08:41:15 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20130307173507.64a55ba3@milhouse> References: <1362671247-10766-1-git-send-email-zajec5@gmail.com> <1362671247-10766-12-git-send-email-zajec5@gmail.com> <20130307173507.64a55ba3@milhouse> Date: Thu, 7 Mar 2013 17:41:14 +0100 Message-ID: (sfid-20130307_174120_583966_49342CCB) Subject: Re: [PATCH 11/13] b43: HT-PHY: implement RSSI polling From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: =?UTF-8?Q?Michael_B=C3=BCsch?= Cc: linux-wireless@vger.kernel.org, "John W. Linville" , b43-dev@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2013/3/7 Michael Büsch : > On Thu, 7 Mar 2013 16:47:25 +0100 > Rafał Miłecki wrote: > >> + const u16 ctl_regs[3][2] = { >> + { B43_PHY_HT_AFE_C1, B43_PHY_HT_AFE_C1_OVER, }, >> + { B43_PHY_HT_AFE_C2, B43_PHY_HT_AFE_C2_OVER, }, >> + { B43_PHY_HT_AFE_C3, B43_PHY_HT_AFE_C3_OVER, }, >> + }; >> + const u16 radio_r[] = { R2059_SYN, R2059_TXRX0, R2059_RXRX1, }; > >> + u16 phy_regs_to_save[] = { >> + B43_PHY_HT_AFE_C1, B43_PHY_HT_AFE_C1_OVER, >> + 0x848, 0x841, >> + B43_PHY_HT_AFE_C2, B43_PHY_HT_AFE_C2_OVER, >> + 0x868, 0x861, >> + B43_PHY_HT_AFE_C3, B43_PHY_HT_AFE_C3_OVER, >> + 0x888, 0x881, >> + }; > > It usually is better to define tables that are constant as "static const", > so that they are not put on the kernel stack. Thanks, I'll fix that, will just wait a little longer for more comments (if any appear) -- Rafał