Return-path: Received: from nbd.name ([46.4.11.11]:60494 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751791Ab3C0S3n (ORCPT ); Wed, 27 Mar 2013 14:29:43 -0400 Message-ID: <515339AB.30609@openwrt.org> (sfid-20130327_192953_344776_63AD073D) Date: Wed, 27 Mar 2013 19:25:47 +0100 From: John Crispin MIME-Version: 1.0 To: "John W. Linville" CC: Gertjan van Wingerde , "linux-wireless@vger.kernel.org" , "users@rt2x00.serialmonkey.com" Subject: Re: [PATCH] rt2x00: make the driver build for Ralink SoC References: <1363808915-14278-1-git-send-email-blogic@openwrt.org> <3D4497AD-8992-47D6-BCF2-5D738B6AC9B4@gmail.com> <514AB846.9090407@openwrt.org> <20130327171713.GD1868@tuxdriver.com> In-Reply-To: <20130327171713.GD1868@tuxdriver.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 27/03/13 18:17, John W. Linville wrote: > On Thu, Mar 21, 2013 at 08:35:34AM +0100, John Crispin wrote: >>>> Fix up the dependencies to make the driver actually compile on Ralink WiSoC. >>>> >>>> Signed-off-by: John Crispin >>> I don't think this is a proper way to handle this. rt2x00pci.c was only meant to be used for PCI devices; introducing the use of CONFIG_PCI in that file doesn't seem appropriate to me. >>> >>> Unfortunately I am away from my home computer, so I can't look at this properly until the weekend. >>> >> Indeed not the cleanest patch ... after changing the config symbols >> I realized that that is not enough to make the driver actually work >> >> It turns out that inside openwrt the compat-wireless package sets >> CONFIG_RT2800PCI=m to make the driver build and then applies the >> #ifdef'ery to rt2880pci.c >> >> I will try to find the time today or tomorrow to have a closer look at this > Any more word on this? Gabor posted a series as RFC that would fix this properly -> http://rt2x00.serialmonkey.com/pipermail/users_rt2x00.serialmonkey.com/2013-March/005837.html