Return-path: Received: from mail-oa0-f44.google.com ([209.85.219.44]:46745 "EHLO mail-oa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932346Ab3CMTOa (ORCPT ); Wed, 13 Mar 2013 15:14:30 -0400 Message-ID: <5140D011.8060701@lwfinger.net> (sfid-20130313_201442_670511_9576A2B2) Date: Wed, 13 Mar 2013 14:14:25 -0500 From: Larry Finger MIME-Version: 1.0 To: "John W. Linville" CC: b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, zajec5@gmail.com Subject: Re: [PATCH] ssb: pci: Fix flipping of MAC address References: <513e40c2.MDaC+Q82iTl9PpIZ%Larry.Finger@lwfinger.net> <20130313181817.GB19917@tuxdriver.com> In-Reply-To: <20130313181817.GB19917@tuxdriver.com> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/13/2013 01:18 PM, John W. Linville wrote: > On Mon, Mar 11, 2013 at 03:38:26PM -0500, Larry Finger wrote: >> Since commit e565275 entitled "ssb: pci: Standardize a function to get mac >> address", the SPROM readout of the MAC has had the values flipped so that >> 00:11:22:33:44:55 became 11:00:33:22:55:44. The fix has been tested on both >> little- and big-endian architectures. >> >> Reported-by: Rafał Miłecki >> Signed-off-by: Larry Finger >> --- >> >> John, >> >> This bug was introduced in 3.9, and should be fixed there. >> >> Thanks, >> >> Larry >> --- >> >> Index: wireless-testing-new/drivers/ssb/pci.c >> =================================================================== >> --- wireless-testing-new.orig/drivers/ssb/pci.c >> +++ wireless-testing-new/drivers/ssb/pci.c >> @@ -234,8 +234,8 @@ static void sprom_get_mac(char *mac, con >> { >> int i; >> for (i = 0; i < 3; i++) { >> - *mac++ = in[i]; >> *mac++ = in[i] >> 8; >> + *mac++ = in[i]; >> } >> } > > Actually, FWIW it seems to have been introduced in commit > e5652756ff36ed9e1283121f788e6a17117efcab, which is slated for 3.10. > I'm happy to merge it in wireless-next. After further checking, I agree that it is not in 3.9. As long as the fix is merged before 3.10, all will be OK. Sorry for the confusion. Larry