Return-path: Received: from mms1.broadcom.com ([216.31.210.17]:1457 "EHLO mms1.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757325Ab3CDNh3 (ORCPT ); Mon, 4 Mar 2013 08:37:29 -0500 Message-ID: <5134A37D.9000704@broadcom.com> (sfid-20130304_143747_686474_A0CB2055) Date: Mon, 4 Mar 2013 14:37:01 +0100 From: "Arend van Spriel" MIME-Version: 1.0 To: "Akinobu Mita" cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "David S. Miller" , "Michael Chan" , "Thomas Sailer" , "Jean-Paul Roubelat" , "Bing Zhao" , "Brett Rudley" , "Franky (Zhenhui) Lin" , "Hante Meuleman" , brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, linux-hams@vger.kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH -v3 16/23] drivers/net: rename random32() to prandom_u32() References: <1362401911-14074-1-git-send-email-akinobu.mita@gmail.com> <1362401911-14074-17-git-send-email-akinobu.mita@gmail.com> In-Reply-To: <1362401911-14074-17-git-send-email-akinobu.mita@gmail.com> Content-Type: text/plain; charset=iso-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/04/13 13:58, Akinobu Mita wrote: > Use more preferable function name which implies using a pseudo-random > number generator. > > Signed-off-by: Akinobu Mita > Acked-by: Thomas Sailer > Acked-by: Bing Zhao [mwifiex] > Cc: "David S. Miller" > Cc: Michael Chan > Cc: Thomas Sailer > Cc: Jean-Paul Roubelat > Cc: Bing Zhao > Cc: Brett Rudley > Cc: Arend van Spriel > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: brcm80211-dev-list@broadcom.com > Cc: netdev@vger.kernel.org > Cc: linux-hams@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > --- > * Changes from v2 > - add Acked-by: line > - add rename for brcm80211 > > drivers/net/ethernet/broadcom/cnic.c | 4 ++-- > drivers/net/hamradio/baycom_epp.c | 2 +- > drivers/net/hamradio/hdlcdrv.c | 2 +- > drivers/net/hamradio/yam.c | 2 +- > drivers/net/wireless/brcm80211/brcmfmac/p2p.c | 2 +- > drivers/net/wireless/mwifiex/cfg80211.c | 4 ++-- > 6 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c > index 4166e64..bca31a8 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/p2p.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/p2p.c > @@ -1118,7 +1118,7 @@ static void brcmf_p2p_afx_handler(struct work_struct *work) > if (afx_hdl->is_listen&& afx_hdl->my_listen_chan) > /* 100ms ~ 300ms */ > err = brcmf_p2p_discover_listen(p2p, afx_hdl->my_listen_chan, > - 100 * (1 + (random32() % 3))); > + 100 * (1 + (prandom_u32() % 3))); Seems like indentation is wrong now. Please retain the alignment. Regards, Arend