Return-path: Received: from mail-ob0-f170.google.com ([209.85.214.170]:34596 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932589Ab3CEB2N (ORCPT ); Mon, 4 Mar 2013 20:28:13 -0500 Message-ID: <51354A28.3040607@lwfinger.net> (sfid-20130305_022846_649907_EA1D5F6F) Date: Mon, 04 Mar 2013 19:28:08 -0600 From: Larry Finger MIME-Version: 1.0 To: shuah.khan@hp.com CC: brudley@broadcom.com, arend@broadcom.com, frankyl@broadcom.com, linville@tuxdriver.com, seth.forshee@canonical.com, pieterpg@broadcom.com, linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com, netdev@vger.kernel.org, LKML , shuahkhan@gmail.com Subject: Re: [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings References: <1362445374.4591.28.camel@lorien2> In-Reply-To: <1362445374.4591.28.camel@lorien2> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 03/04/2013 07:02 PM, Shuah Khan wrote: > PCI_BUS defined in defs.h results in warnings from all brcm80211 source files > including defs.h. This define is not used in brcm80211. Removing this define > fixes the warning. > > In file included from drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0: > drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default] > include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition > CC [M] drivers/net/wireless/b43legacy/dma.o > CC [M] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o > CC [M] drivers/net/wireless/b43legacy/pio.o > In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0: > drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default] > include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition > In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0: > drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default] > include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition Strange, I do not see PCI_BUS defined anywhere in the include/ branch in either 3.8 or 3.9. In addition, I don't get these warnings. What is different in your system? Larry > > Signed-off-by: Shuah Khan > --- > drivers/net/wireless/brcm80211/include/defs.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/include/defs.h b/drivers/net/wireless/brcm80211/include/defs.h > index fb7cbcf..3608436 100644 > --- a/drivers/net/wireless/brcm80211/include/defs.h > +++ b/drivers/net/wireless/brcm80211/include/defs.h > @@ -20,7 +20,6 @@ > #include > > #define SI_BUS 0 > -#define PCI_BUS 1 > #define PCMCIA_BUS 2 > #define SDIO_BUS 3 > #define JTAG_BUS 4 >