Date: Thu, 28 Mar 2013 01:21:08 -0400 (EDT)
Message-Id: <20130328.012108.961738246524996742.davem@davemloft.net> (sfid-20130328_062128_799486_8D8CF4EE)
To: horms@verge.net.au
Cc: jesse@nicira.com, isdn@linux-pingi.de, linville@tuxdriver.com,
	johannes@sipsolutions.net, bart.de.schuymer@pandora.be,
	stephen@networkplumber.org, kaber@trash.net, marcel@holtmann.org,
	gustavo@padovan.org, johan.hedberg@gmail.com,
	linux-bluetooth@vger.kernel.org, netfilter-devel@vger.kernel.org,
	bridge@lists.linux-foundation.org, linux-wireless@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, linux-media@vger.kernel.org,
	netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [PATCH v2] net: add ETH_P_802_3_MIN
From: David Miller <davem@davemloft.net>
In-Reply-To: <1364445505-9745-1-git-send-email-horms@verge.net.au>
References: <1364445505-9745-1-git-send-email-horms@verge.net.au>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org

From: Simon Horman <horms@verge.net.au>
Date: Thu, 28 Mar 2013 13:38:25 +0900

> Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for
> an 802.3 frame. Frames with a lower value in the ethernet type field
> are Ethernet II.
> 
> Also update all the users of this value that David Miller and
> I could find to use the new constant.
> 
> Also correct a bug in util.c. The comparison with ETH_P_802_3_MIN
> should be >= not >.
> 
> As suggested by Jesse Gross.
> 
> Compile tested only.
> 
> Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> Acked-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> Signed-off-by: Simon Horman <horms@verge.net.au>

Looks great, applied, thanks Simon.