Return-path: Received: from mail-qe0-f43.google.com ([209.85.128.43]:43901 "EHLO mail-qe0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751834Ab3CSBCb (ORCPT ); Mon, 18 Mar 2013 21:02:31 -0400 Date: Mon, 18 Mar 2013 21:02:26 -0400 (EDT) From: Parag Warudkar To: "Luis R. Rodriguez" cc: "John W. Linville" , Parag Warudkar , Jouni Malinen , Vasanthakumar Thiagarajan , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net, netdev@vger.kernel.org, LKML , senthilb@qca.qualcomm.com Subject: Re: [PATCH] ath9k : Fix ieee80211 work while going to suspend In-Reply-To: <20130318210308.GD32416@pogo> Message-ID: (sfid-20130319_020247_640838_1BC7F505) References: <20130318191340.GA28919@tuxdriver.com> <20130318210308.GD32416@pogo> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 18 Mar 2013, Luis R. Rodriguez wrote: > > Note that what this will do is call later mod_timer() for > rx_poll_timer, the right thing to do then, which would > be equivalent to your patch is to modify the ath_start_rx_poll() > to instead use the new API mod_timer_pending() added on v2.6.30 > via commit 74019224. This would not re-arm the timer if it was > previously removed. Thanks for the details Luis. Converting to mod_timer_pending() seems to do the trick as well. Parag