Return-path: Received: from mail-la0-f51.google.com ([209.85.215.51]:35439 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757486Ab3CDR67 (ORCPT ); Mon, 4 Mar 2013 12:58:59 -0500 MIME-Version: 1.0 In-Reply-To: <20130304154832.GD3021@redhat.com> References: <20130304134949.GB3021@redhat.com> <20130304154832.GD3021@redhat.com> Date: Mon, 4 Mar 2013 19:58:57 +0200 Message-ID: (sfid-20130304_185905_236146_BFAA8BA6) Subject: Re: is L1 really disabled in iwlwifi From: Emmanuel Grumbach To: Stanislaw Gruszka Cc: linux-pci@vger.kernel.org, linux-wireless , John Linville Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Mar 4, 2013 at 5:48 PM, Stanislaw Gruszka wrote: > On Mon, Mar 04, 2013 at 04:57:46PM +0200, Emmanuel Grumbach wrote: > >> This is what I did. On 3.7, lspci tells me that ASPM is enabled before >> I load the module. And same after I load the module. > > CONFIG_PCIEASPM disabled ? > nope - enabled on both kernel: 3.1 and 3.7. Makes sense though. CONFIG_PCIEASPM enabled, I have L1. Just wondering why doesn't that pci_disable_link_state do anything.... Also, I remember so issues Mathew Garret debugged and he ended up disabling ASPM on older kernel because some BIOS issue (don't remember really). Apparently, ASPM is enabled again in newer kernels. Anyway - I think I will just remove this pci_disable_link_state call and hopefully, it will stay long enough in linux-next so that people will report issues before it get into linux. I don't like leaving that code if it doesn't do anything.