Return-path: Received: from nbd.name ([46.4.11.11]:34034 "EHLO nbd.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040Ab3CKVhC (ORCPT ); Mon, 11 Mar 2013 17:37:02 -0400 Message-ID: <513E4E76.2000000@openwrt.org> (sfid-20130311_223708_688647_0B2C2441) Date: Mon, 11 Mar 2013 22:36:54 +0100 From: Felix Fietkau MIME-Version: 1.0 To: Ben Greear CC: "John W. Linville" , linux-wireless@vger.kernel.org, ath9k-devel@venema.h4ckr.net Subject: Re: [PATCH] ath9k: Allow over-riding reg-domain. References: <1363020306-924-1-git-send-email-greearb@candelatech.com> <20130311190537.GB32171@tuxdriver.com> <513E35CD.3010006@candelatech.com> <513E3BE8.1000909@openwrt.org> <513E4617.2020906@candelatech.com> In-Reply-To: <513E4617.2020906@candelatech.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2013-03-11 10:01 PM, Ben Greear wrote: > On 03/11/2013 01:17 PM, Felix Fietkau wrote: >> On 2013-03-11 8:51 PM, Ben Greear wrote: >>> On 03/11/2013 12:05 PM, John W. Linville wrote: >>>> On Mon, Mar 11, 2013 at 09:45:06AM -0700, greearb@candelatech.com wrote: >>>>> From: Ben Greear >>>>> >>>>> Otherwise, can't get the Sparklan AR9380 NICs to be >>>>> 5Ghz APs, since they are in world-roaming domain by >>>>> default. Add this to /etc/modprobe.d/ath9k.conf: >>>>> >>>>> options ath9k override_eeprom_regdomain=0 >>>>> >>>>> Signed-off-by: Ben Greear >>>> >>>> Why "=0" to enable it? Just to make it more confusing? >>> >>> You are just setting the country code...and country-code 0 seems >>> to at least open up the US regulatory domain so we use it >>> by default. >>> >>> You can use any country code you wish here. >> I'd like to have less fugly module parameter hackery please. How about >> either using CONFIG_CFG80211_CERTIFICATION_ONUS the way it was intended, >> or adding another config option that makes it bail out of >> ath_regd_init_wiphy() early, thus still processing the EEPROM regdomain >> hint and not making it binding. > > I am not sure what you are suggesting. I enabled this override > only when ONUS is selected because I wanted it clear that users > were taking their regulatory compliance into their own hands. And as far as I understand, CONFIG_CFG80211_CERTIFICATION_ONUS already enables some code in cfg80211 that allows a special type of regulatory change request from user space that bypasses intersection. > I always want the module option at least visible so that > you don't have to muck with modprobe.conf just to get ath9k.ko > to load when it's compiled differently. > > For the second part, you want the ability to set the regdomain > be a compile-time option like CONFIG_ATH9K_OVERRIDE_REGDOMAIN > or something like that? Something like that, yes. It should depend on CONFIG_CFG80211_CERTIFICATION_ONUS and should contain a help text that strongly discourages any distribution from enabling it in their kernel builds. - Felix