Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:48473 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315Ab3DYFtN (ORCPT ); Thu, 25 Apr 2013 01:49:13 -0400 Date: Thu, 25 Apr 2013 01:49:11 -0400 (EDT) Message-Id: <20130425.014911.738013858577867185.davem@davemloft.net> (sfid-20130425_074925_046450_B825DEBB) To: dan.carpenter@oracle.com Cc: lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com, linville@tuxdriver.com, thierry.escande@linux.intel.com, levinsasha928@gmail.com, linux-wireless@vger.kernel.org, linux-nfc@ml01.01.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] NFC: llcp: two bugs in ->getname() From: David Miller In-Reply-To: <20130423062452.GD15893@elgon.mountain> References: <20130423062452.GD15893@elgon.mountain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Dan Carpenter Date: Tue, 23 Apr 2013 09:24:52 +0300 > The sockaddr_nfc_llcp struct has as hole between ->sa_family and > ->dev_idx so I've added a memset() to clear it and prevent an > information leak. > > Also the ->nfc_protocol element wasn't set so I've added that. > > "uaddr->sa_family" and "llcp_addr->sa_family" are the same thing but > it's less confusing to use llcp_addr consistently throughout. > > Signed-off-by: Dan Carpenter Applied.