Message-ID: <1365502750.8465.30.camel@jlt4.sipsolutions.net> (sfid-20130409_121925_585764_5E93C1E8)
Subject: Re: RFC: SMPS for AP mode
From: Johannes Berg <johannes@sipsolutions.net>
To: vivekanandah@posedge.com
Cc: linux-wireless@vger.kernel.org, nbd@openwrt.org
Date: Tue, 09 Apr 2013 12:19:10 +0200
In-Reply-To: <021a065e3ab402466e8049b2f4cd3fdd@posedge.com>
References: <fbef7a2278fe739a398430949087c950@posedge.com>
	 (sfid-20130403_093709_189406_740B7438) <1364976319.8351.2.camel@jlt4.sipsolutions.net>
	 <7a1a483e9382db42e8f648c3933bc2cd@posedge.com>
	 <1364978764.8351.6.camel@jlt4.sipsolutions.net>
	 <021a065e3ab402466e8049b2f4cd3fdd@posedge.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

Hi,

> based on the discussion, i have come out with an RFC for SMPS support 
> for AP in minstrel_ht. kindly see the explanation below and indicate to 
> me, if this okay or any changes are required?

Code talks ;-)

> RFC To send out RTS for AP connected to a dynamic SMPS station
> 
> This code change addresses the AP requirement of sending out a
> RTS frame when dynamic SMPS is enabled at the station
> 
> the minstrel_ht rate module needs to provide the lower driver layer
> an indication of enabling RTS frame transmission for an AP connected
> to a dynamic SMPS station.

It really just needs to set the RTS flag on the frames.

> the SMPS state of the station is stored in the ieee80211_sta 
> structure's ht_cap variable.

No, not any more.

> the minstrel_ht_get_rate function can be modified to check if the 
> station is a dynamic SMPS
> station and a new flag can be incorporated for the ieee80211_tx_info 
> flags (e.g. IEEE80211_TX_CTL_SMPS_SET_RTS)
> that indicates to the lower layer that the station is a dynamic SMPS 
> enabled station.
> 
> the lower AP driver can then enable RTS before the first frame 
> transmission to the station by checking for the above flag.

Sounds about right.

johannes