Return-path: Received: from mail-wg0-f45.google.com ([74.125.82.45]:50588 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758241Ab3DIK7n (ORCPT ); Tue, 9 Apr 2013 06:59:43 -0400 Received: by mail-wg0-f45.google.com with SMTP id x12so6986952wgg.24 for ; Tue, 09 Apr 2013 03:59:42 -0700 (PDT) Date: Tue, 9 Apr 2013 12:55:51 +0200 From: Karl Beldan To: Johannes Berg Cc: linux-wireless , Karl Beldan Subject: Re: [PATCH] mac80211: always pick a basic rate to tx RTS/CTS for pre-HT rates Message-ID: <20130409105535.GA27875@magnum.frso.rivierawaves.com> (sfid-20130409_125947_554914_72FCDAF9) References: <1365156384-6699-1-git-send-email-karl.beldan@gmail.com> <1365503356.8465.37.camel@jlt4.sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1365503356.8465.37.camel@jlt4.sipsolutions.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Apr 09, 2013 at 12:29:16PM +0200, Johannes Berg wrote: > On Fri, 2013-04-05 at 12:06 +0200, Karl Beldan wrote: > > From: Karl Beldan > > > > When the 1st rate control entry is a pre-HT rate we want to set > > rts_cts_rate_idx "as the fastest basic rate that is not faster than the > > data rate"(code comments). > > But in case some bss allowed rate indexes are lower than the lowest bss > > basic rate, if the rate control selects a rate among the formers for its > > 1st rate control entry, rts_cts_rate_idx remains 0 and is not a basic > > rate index. > > This commit sets rts_cts_rate_idx to the lowest bss basic rate index in > > this situation. > > I guess it's a good thing you're looking at this code. However, I'm not > sure what you're doing here is correct. In this case, the PHY mandatory > rates should be used. See 9.7.6.5.2 "Selection of a rate or MCS": > Thanks for looking at this. You are quoting the chapter for "control _response_ frames" which does not apply here (even CTS-to-self are not control response frames). Karl