Message-ID: <1369669990.14740.14.camel@jlt4.sipsolutions.net> (sfid-20130527_175329_645567_87157644)
Subject: Re: P2P Device support: how to deal with p2p_no_group_iface option
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: Jouni Malinen <j@w1.fi>,
	"hostap@lists.shmoo.com" <hostap@lists.shmoo.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Jithu Jance <jithu@broadcom.com>
Date: Mon, 27 May 2013 17:53:10 +0200
In-Reply-To: <51A367CB.9080503@broadcom.com>
References: <51A09F43.5030004@broadcom.com>
	 <1369645418.8229.17.camel@jlt4.sipsolutions.net>
	 <51A36603.7020403@broadcom.com>
	 <1369663161.14740.13.camel@jlt4.sipsolutions.net>
	 <51A367CB.9080503@broadcom.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

On Mon, 2013-05-27 at 16:03 +0200, Arend van Spriel wrote:
> On 05/27/2013 03:59 PM, Johannes Berg wrote:
> > On Mon, 2013-05-27 at 15:56 +0200, Arend van Spriel wrote:
> >
> >>> I don't think I'd do either of those. Not creating P2P_DEVICE will
> >>> simply not work with drivers expecting it, and changing iftype to/from
> >>> P2P-Device isn't supported since it would delete/create the netdev.
> >>
> >> So should we check that in cfg80211 upon wiphy_register().
> >
> > Check what?
> 
> Check that the interface combinations contain a iface limit with only 
> P2P_DEVICE:
> 
> 	{
> 		.max = 1,
> 		.types = BIT(NL80211_IFTYPE_P2P_DEVICE)
> 	}

We have that, right?

wiphy_verify_combinations:
                        /* Only a single P2P_DEVICE can be allowed */
                        if (WARN_ON(types &
BIT(NL80211_IFTYPE_P2P_DEVICE) &&
                                    c->limits[j].max > 1))
                                return -EINVAL;

johannes