Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:33870 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758477Ab3E2TwS (ORCPT ); Wed, 29 May 2013 15:52:18 -0400 Message-ID: <1369857129.12820.5.camel@jlt4.sipsolutions.net> (sfid-20130529_215221_985597_4EBA8B9A) Subject: Re: [PATCH] mac80211: mesh formation info properly set From: Johannes Berg To: Jacob Minshall Cc: linux-wireless@vger.kernel.org, devel@lists.open80211s.org Date: Wed, 29 May 2013 21:52:09 +0200 In-Reply-To: <1369855313-25871-1-git-send-email-jacob@cozybit.com> (sfid-20130529_212202_758720_0E1A739C) References: <1369855313-25871-1-git-send-email-jacob@cozybit.com> (sfid-20130529_212202_758720_0E1A739C) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 2013-05-29 at 12:21 -0700, Jacob Minshall wrote: > Max peerings capped at 63 in accordance with IEEE-2012 8.4.2.100.7, > and trigger a beacon regeneration every time the number of peerings > changes. Can you write full sentences? Maybe also in the subject ("set mesh ... properly"?) :-) > - neighbors = (neighbors > 15) ? 15 : neighbors; > + neighbors = (neighbors > IEEE80211_MAX_MESH_PEERINGS) ? > + IEEE80211_MAX_MESH_PEERINGS : neighbors; min() or min_t()? > atomic_inc(&sdata->u.mesh.estab_plinks); > - return mesh_accept_plinks_update(sdata); > + mesh_accept_plinks_update(sdata); > + return BSS_CHANGED_BEACON; These changes seem odd to me, why doesn't mesh_accept_plinks_update() just return the change value then? johannes