Return-path: Received: from mail-oa0-f48.google.com ([209.85.219.48]:45320 "EHLO mail-oa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755024Ab3ETBIr (ORCPT ); Sun, 19 May 2013 21:08:47 -0400 Received: by mail-oa0-f48.google.com with SMTP id i4so7058280oah.21 for ; Sun, 19 May 2013 18:08:46 -0700 (PDT) Message-ID: <51997798.8000703@lwfinger.net> (sfid-20130520_030850_359781_D5CCE661) Date: Sun, 19 May 2013 20:08:40 -0500 From: Larry Finger MIME-Version: 1.0 To: Hauke Mehrtens CC: mcgrof@kernel.org, linux-wireless@vger.kernel.org Subject: Re: [PATCH 2/2] backports: defconfig for rtlwifi family References: <1368981836-6247-1-git-send-email-Larry.Finger@lwfinger.net> <1368981836-6247-2-git-send-email-Larry.Finger@lwfinger.net> <5199581F.4090506@hauke-m.de> In-Reply-To: <5199581F.4090506@hauke-m.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 05/19/2013 05:54 PM, Hauke Mehrtens wrote: > On 05/19/2013 06:43 PM, Larry Finger wrote: >> Signed-off-by: Larry Finger >> --- >> >> V2 in proper format for git repo >> >> Larry >> >> backport/defconfigs/rtlwifi | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 backport/defconfigs/rtlwifi >> >> diff --git a/backport/defconfigs/rtlwifi b/backport/defconfigs/rtlwifi >> new file mode 100644 >> index 0000000..c86d000 >> --- /dev/null >> +++ b/backport/defconfigs/rtlwifi >> @@ -0,0 +1,19 @@ >> +CPTCFG_CFG80211=m >> +CPTCFG_CFG80211_DEFAULT_PS=y >> +CPTCFG_CFG80211_DEBUGFS=y >> +CPTCFG_MAC80211=m >> +# CPTCFG_MAC80211_RC_PID is not set >> +# CPTCFG_MAC80211_RC_MINSTREL is not set >> +# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set > > This results in no rate control mechanism being selected is that intended? > > MAC80211_MESH and MAC80211_LEDS are also not selected. > >> +CPTCFG_MAC80211_DEBUGFS=y >> +CPTCFG_MAC80211_MESSAGE_TRACING=y >> +CPTCFG_WLAN=y >> +CPTCFG_RTLWIFI=m >> +CPTCFG_RTLWIFI_DEBUG=y >> +CPTCFG_RTL8192CE=m >> +CPTCFG_RTL8192SE=m >> +CPTCFG_RTL8192DE=m >> +CPTCFG_RTL8723AE=m >> +CPTCFG_RTL8188EE=m >> +CPTCFG_RTL8192CU=m >> +CPTCFG_RTL8192C_COMMON=m The rtlwifi drivers do rate control in the firmware. That is OK, but LEDS and MESH should be selected. Thanks for noticing, Larry