Date: Tue, 04 Jun 2013 13:18:13 -0700 (PDT)
Message-Id: <20130604.131813.134898245916084893.davem@davemloft.net> (sfid-20130604_221910_591796_A119E8D4)
To: linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: pull request: wireless 2013-06-03
From: David Miller <davem@davemloft.net>
In-Reply-To: <20130603184817.GD2727@tuxdriver.com>
References: <20130603184817.GD2727@tuxdriver.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Sender: linux-wireless-owner@vger.kernel.org

From: "John W. Linville" <linville@tuxdriver.com>
Date: Mon, 3 Jun 2013 14:48:17 -0400

> Please let me know if there are problems!

Sorry, the broadcom brcmfmac changes need to go.

Some of those commits are cleanups, and some of them have the worst
commit log messages ever, the last one for example:

0017-brcmsmac-fix-regression-observed-in-3.10-rc1.patch

has no explanation whatsoever of what the actual problem or regression
is, what aspect of the logic in that function is causing the problem,
and no explanation why making this function always return 'false' is a
reasonable fix.

That entire series is of very low quality, and even if it was in good
shape, at least half the changes are not appropriate at all this late
in the -rc series.