Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:33957 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756346Ab3FMRaR (ORCPT ); Thu, 13 Jun 2013 13:30:17 -0400 Date: Thu, 13 Jun 2013 13:30:02 -0400 From: "John W. Linville" To: Bing Zhao Cc: Ben Greear , Kalle Valo , "linux-wireless@vger.kernel.org" , Amitkumar Karwar , Avinash Patil , Yogesh Powar , Nishant Sarmukadam , Frank Huang , Paul Stewart Subject: Re: [PATCH] mwifiex: Add module parameter for regdomain Message-ID: <20130613173002.GC3246@tuxdriver.com> (sfid-20130613_193039_725780_B79B258C) References: <1370904007-10959-1-git-send-email-bzhao@marvell.com> <877ghz3il6.fsf@purkki.adurom.net> <477F20668A386D41ADCC57781B1F70430EA268B457@SC-VEXCH1.marvell.com> <8738sn2mcf.fsf@purkki.adurom.net> <51B8C41E.7050907@candelatech.com> <477F20668A386D41ADCC57781B1F70430EA268B4A3@SC-VEXCH1.marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <477F20668A386D41ADCC57781B1F70430EA268B4A3@SC-VEXCH1.marvell.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 12, 2013 at 12:01:23PM -0700, Bing Zhao wrote: > > > >> "iw reg set XX" or "country_code=XX" in hostapd.conf is a *user* hint. > > >> > > >> What we need here is a *driver* hint. Furthermore, with a driver > > >> regulatory hint, the passive-scan and no-ibss flags are cleared so we > > >> can start AP with hostapd on 5G band. > > > > > > So it's a driver hint which is coming from user space via a module > > > parameter. IMHO you are abusing interfaces here. Is there any better way > > > to solve your problem? > > > > It would be nice to have some way to do this for ath9k and other NICs > > as well. Best I could come up with is a similar hack for ath9k. > > > > I think part of the problem is that this config info needs to be > > available very early in the module loading/init logic, so it's > > too late to be configured using 'iw' or similar. > > Exactly. regulatory_hint () needs to be called right after wiphy registration. It does seem a bit ugly. But if Marvell wants it, I don't see any "regulatory" argument to disallow something like this. Does anyone have a better suggestion for a user interface for such a feature? John -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.