Return-path: Received: from mail-ob0-f173.google.com ([209.85.214.173]:39525 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752807Ab3FFJSS (ORCPT ); Thu, 6 Jun 2013 05:18:18 -0400 Received: by mail-ob0-f173.google.com with SMTP id wc20so4227086obb.4 for ; Thu, 06 Jun 2013 02:18:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1369822703-27769-1-git-send-email-sachin.kamat@linaro.org> References: <1369822703-27769-1-git-send-email-sachin.kamat@linaro.org> Date: Thu, 6 Jun 2013 14:48:17 +0530 Message-ID: (sfid-20130606_111824_069719_D2A22B98) Subject: Re: [PATCH 1/2] net: wireless: wl1251: Use module_spi_driver macro From: Sachin Kamat To: linux-wireless@vger.kernel.org Cc: linville@tuxdriver.com, sachin.kamat@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 29 May 2013 15:48, Sachin Kamat wrote: > module_spi_driver() eliminates some boiler plate and makes code > simpler. > > Signed-off-by: Sachin Kamat > --- > drivers/net/wireless/ti/wl1251/spi.c | 24 +----------------------- > 1 file changed, 1 insertion(+), 23 deletions(-) > > diff --git a/drivers/net/wireless/ti/wl1251/spi.c b/drivers/net/wireless/ti/wl1251/spi.c > index 4c67c2f..dfd0877 100644 > --- a/drivers/net/wireless/ti/wl1251/spi.c > +++ b/drivers/net/wireless/ti/wl1251/spi.c > @@ -329,29 +329,7 @@ static struct spi_driver wl1251_spi_driver = { > .remove = wl1251_spi_remove, > }; > > -static int __init wl1251_spi_init(void) > -{ > - int ret; > - > - ret = spi_register_driver(&wl1251_spi_driver); > - if (ret < 0) { > - wl1251_error("failed to register spi driver: %d", ret); > - goto out; > - } > - > -out: > - return ret; > -} > - > -static void __exit wl1251_spi_exit(void) > -{ > - spi_unregister_driver(&wl1251_spi_driver); > - > - wl1251_notice("unloaded"); > -} > - > -module_init(wl1251_spi_init); > -module_exit(wl1251_spi_exit); > +module_spi_driver(wl1251_spi_driver); > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Kalle Valo "); > -- > 1.7.9.5 > Gentle ping on this series John. -- With warm regards, Sachin