Return-path: Received: from arrakis.dune.hu ([78.24.191.176]:46601 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119Ab3FXTAu (ORCPT ); Mon, 24 Jun 2013 15:00:50 -0400 Message-ID: <51C89764.8000700@openwrt.org> (sfid-20130624_210111_086449_F3692AB1) Date: Mon, 24 Jun 2013 21:00:52 +0200 From: Gabor Juhos MIME-Version: 1.0 To: Helmut Schaa CC: John Linville , linux-wireless , rt2x00 Users List Subject: Re: [PATCH 2/3] rt2x00: rt2800lib: turn on secondary PAs/LNAs for 3T/3R devices References: <1371915734-13966-1-git-send-email-juhosg@openwrt.org> <1371915734-13966-3-git-send-email-juhosg@openwrt.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2013.06.24. 15:00 keltez?ssel, Helmut Schaa ?rta: > On Sat, Jun 22, 2013 at 5:42 PM, Gabor Juhos wrote: >> The secondary PAs/LNAs are turned on only for 2T/2R >> devices, however these are used for 3T/3R devices as >> well. Always turn those on if the device uses more >> than one tx/rx chains. >> >> Signed-off-by: Gabor Juhos >> --- >> drivers/net/wireless/rt2x00/rt2800lib.c | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c >> index 4072242..f4cd3d8 100644 >> --- a/drivers/net/wireless/rt2x00/rt2800lib.c >> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c >> @@ -2678,16 +2678,16 @@ static void rt2800_config_channel(struct rt2x00_dev *rt2x00dev, >> >> tx_pin = 0; >> >> - /* Turn on unused PA or LNA when not using 1T or 1R */ >> - if (rt2x00dev->default_ant.tx_chain_num == 2) { >> + if (rt2x00dev->default_ant.tx_chain_num > 1) { >> + /* Turn on secondary PAs for 2T adn for 3T devices*/ > > Typo adn -> and. > > Otherwise looks good to me. Thanks, I will send a fixed version. -Gabor