Return-path: Received: from mail.net.t-labs.tu-berlin.de ([130.149.220.252]:57802 "EHLO mail.net.t-labs.tu-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752999Ab3FGWLP convert rfc822-to-8bit (ORCPT ); Fri, 7 Jun 2013 18:11:15 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [PATCH 1/3] mac80211: restructure tx_control_flag handling in ieee80211_tx_info From: =?windows-1252?Q?Thomas_H=FChn?= In-Reply-To: <1370628803-28785-2-git-send-email-thomas@net.t-labs.tu-berlin.de> Date: Sat, 8 Jun 2013 00:11:11 +0200 Cc: linux-wireless@vger.kernel.org, nbd@nbd.name, johannes@sipsolutions.net, bvahl@net.t-labs.tu-berlin.de Message-Id: <38635050-E94D-4FED-8DED-51AD53E9D4F6@net.t-labs.tu-berlin.de> (sfid-20130608_001118_228261_11F2AE74) References: <1370628803-28785-1-git-send-email-thomas@net.t-labs.tu-berlin.de> <1370628803-28785-2-git-send-email-thomas@net.t-labs.tu-berlin.de> To: linville@tuxdriver.com Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi all, This initial PATCH 1/3 does not compile? will sent v2. Greetings Thomas On 07.06.2013, at 20:13, Thomas Huehn wrote: > All usable bits in enum mac80211_tx_control_flags are depleted. In > order to allow aditional control flag assigments, we introduce a > new u16 variable ieee8011_tx_info->control.flags2 with its > corresponding enum mac80211_tx_control_flags2. Such tx control flags > within ieee80211_tx_info->flags that are only used in the tx path > while ieee80211_tx_info->control is valid can be moved to > ieee80211_tx_control->control.flags2. > > Signed-off-by: Thomas Huehn > --- > include/net/mac80211.h | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/include/net/mac80211.h b/include/net/mac80211.h > index a405a7a..2d8e461 100644 > --- a/include/net/mac80211.h > +++ b/include/net/mac80211.h > @@ -500,6 +500,15 @@ enum mac80211_tx_control_flags { > IEEE80211_TX_CTL_PS_RESPONSE = BIT(31), > }; > > +/** > + * enum mac80211_tx_control_flags2 - control related flags to describe transmission information/status > + * > + * These flags are used with the @flags2 member of &ieee80211_tx_info inside control > + * and are only available within the tx path where tx_info->control is valid. > + */ > +enum mac80211_tx_control_flags2 { > +}; > + > #define IEEE80211_TX_CTL_STBC_SHIFT 23 > > /* > @@ -675,7 +684,8 @@ struct ieee80211_tx_info { > /* NB: vif can be NULL for injected frames */ > struct ieee80211_vif *vif; > struct ieee80211_key_conf *hw_key; > - /* 8 bytes free */ > + u16 flags2; > + /* 6 bytes free */ > } control; > struct { > struct ieee80211_tx_rate rates[IEEE80211_TX_MAX_RATES]; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html