Date: Tue, 11 Jun 2013 16:59:11 -0400
From: "John W. Linville" <linville@tuxdriver.com>
To: Yunlian Jiang <yunlian@google.com>
Cc: linux-wireless@vger.kernel.org, Larry.Finger@lwfinger.net,
	chaoming_li@realsil.com.cn, davem@davemloft.net
Subject: Re: [PATCH] rtlwifi: initialize local array and set value.
Message-ID: <20130611205911.GB2142@tuxdriver.com> (sfid-20130611_230021_946081_6A6225C1)
References: <1370036721-18164-1-git-send-email-yunlian@google.com>
 <20130603193947.GH2727@tuxdriver.com>
 <CAMsPy2sqS8frL+Ybq2YT83ehfZ9bSgyfwuZmfDf1R4tCre8O1g@mail.gmail.com>
 <20130603210707.GL2727@tuxdriver.com>
 <CAMsPy2vQzhdy9xzUzk+xWt_EXDbFmGUStJPRXvr1LG85v-NVRQ@mail.gmail.com>
 <CAMsPy2ufj3TjdWbpPKq7QqS_ELAmqhA_Djo6dwcevLym2PCkDQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <CAMsPy2ufj3TjdWbpPKq7QqS_ELAmqhA_Djo6dwcevLym2PCkDQ@mail.gmail.com>
Sender: linux-wireless-owner@vger.kernel.org

It's in wireless-next...

commit ec71997eff2231098212a99934c0fb987a9e6b04
Author: Yunlian Jiang <yunlian@google.com>
Date:   Fri May 31 14:45:21 2013 -0700

    rtlwifi: initialize local array and set value.
    
    GCC 4.8 is spitting out uninitialized-variable warnings against
    "drivers/net/wireless/rtlwifi/rtl8192de/dm.c".
    
    drivers/net/wireless/rtlwifi/rtl8192de/dm.c:941:31:
    error: 'ofdm_index_old[1]' may be used uninitialized in this
    function [-Werror=maybe-uninitialized]
         rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
    
    This patch adds initialization to the variable and properly sets its value.
    
    Signed-off-by: Yunlian Jiang <yunlian@google.com>
    Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
    Signed-off-by: John W. Linville <linville@tuxdriver.com>

On Tue, Jun 11, 2013 at 01:00:00PM -0700, Yunlian Jiang wrote:
> John,
>    Any update for this patch?
>    Thanks
> 
> 
> On Mon, Jun 3, 2013 at 2:17 PM, Yunlian Jiang <yunlian@google.com> wrote:
> 
> > John,
> >    Yes, I intended for it to be there and please add it.
> >
> >    Thanks
> >
> >
> > On Mon, Jun 3, 2013 at 2:07 PM, John W. Linville <linville@tuxdriver.com>wrote:
> >
> >> That would be perfectly fine.  Or, you can just acknowledge that you
> >> intended for it to be there and I can add it myself.
> >>
> >> John
> >>
> >> On Mon, Jun 03, 2013 at 12:48:31PM -0700, Yunlian Jiang wrote:
> >> > Sorry, can I re-upload the patch and set Signed-off-by me?
> >> >
> >> > Thanks
> >> >
> >> >
> >> > On Mon, Jun 3, 2013 at 12:39 PM, John W. Linville <
> >> linville@tuxdriver.com>wrote:
> >> >
> >> > > This patch is missing a Signed-off-by line...
> >> > >
> >> > > On Fri, May 31, 2013 at 02:45:21PM -0700, Yunlian Jiang wrote:
> >> > > > GCC 4.8 is spitting out uninitialized-variable warnings against
> >> > > > "drivers/net/wireless/rtlwifi/rtl8192de/dm.c".
> >> > > >
> >> > > > drivers/net/wireless/rtlwifi/rtl8192de/dm.c:941:31:
> >> > > > error: 'ofdm_index_old[1]' may be used uninitialized in this
> >> > > > function [-Werror=maybe-uninitialized]
> >> > > >      rtlpriv->dm.ofdm_index[i] = ofdm_index_old[i];
> >> > > >
> >> > > > This patch adds initialization to the variable and properly sets its
> >> > > value.
> >> > > > ---
> >> > > >  drivers/net/wireless/rtlwifi/rtl8192de/dm.c | 2 +-
> >> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >> > > >
> >> > > > diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> >> > > b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> >> > > > index 19a7655..47875ba 100644
> >> > > > --- a/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> >> > > > +++ b/drivers/net/wireless/rtlwifi/rtl8192de/dm.c
> >> > > > @@ -842,7 +842,7 @@ static void
> >> > > rtl92d_dm_txpower_tracking_callback_thermalmeter(
> >> > > >       long val_y, ele_c = 0;
> >> > > >       u8 ofdm_index[2];
> >> > > >       s8 cck_index = 0;
> >> > > > -     u8 ofdm_index_old[2];
> >> > > > +     u8 ofdm_index_old[2] = {0, 0};
> >> > > >       s8 cck_index_old = 0;
> >> > > >       u8 index;
> >> > > >       int i;
> >> > > > --
> >> > > > 1.8.2.1
> >> > > >
> >> > > > --
> >> > > > To unsubscribe from this list: send the line "unsubscribe
> >> > > linux-wireless" in
> >> > > > the body of a message to majordomo@vger.kernel.org
> >> > > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >> > > >
> >> > >
> >> > > --
> >> > > John W. Linville                Someday the world will need a hero,
> >> and you
> >> > > linville@tuxdriver.com                  might be all we have.  Be
> >> ready.
> >> > >
> >>
> >> --
> >> John W. Linville                Someday the world will need a hero, and
> >> you
> >> linville@tuxdriver.com                  might be all we have.  Be ready.
> >>
> >
> >

-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.