Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:34725 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755311Ab3FDOpK (ORCPT ); Tue, 4 Jun 2013 10:45:10 -0400 From: Joe Perches To: linux-kernel@vger.kernel.org Cc: Solomon Peachy , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 4/4] cw1200: hwio: Remove an unnecessary goto Date: Tue, 4 Jun 2013 07:44:50 -0700 Message-Id: (sfid-20130604_164533_006538_81EE9BA0) In-Reply-To: <60123fd3175b7cceadf6c335b12e58b797e18f65.1370356776.git.joe@perches.com> References: <60123fd3175b7cceadf6c335b12e58b797e18f65.1370356776.git.joe@perches.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: goto after return is wrong. The other code in this block needs to set an error value then goto an error release block. This one doesn't need to release anything and was likely a copy/paste remainder. Signed-off-by: Joe Perches --- drivers/net/wireless/cw1200/hwio.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/cw1200/hwio.c b/drivers/net/wireless/cw1200/hwio.c index 142f45ef..dad3fb3 100644 --- a/drivers/net/wireless/cw1200/hwio.c +++ b/drivers/net/wireless/cw1200/hwio.c @@ -178,7 +178,6 @@ int cw1200_indirect_read(struct cw1200_common *priv, u32 addr, void *buf, if ((buf_len / 2) >= 0x1000) { pr_err("Can't read more than 0xfff words.\n"); return -EINVAL; - goto out; } priv->hwbus_ops->lock(priv->hwbus_priv); -- 1.8.1.2.459.gbcd45b4.dirty