Return-path: Received: from comal.ext.ti.com ([198.47.26.152]:51103 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746Ab3F0NYC (ORCPT ); Thu, 27 Jun 2013 09:24:02 -0400 Message-ID: <51CC3CEE.3050004@ti.com> (sfid-20130627_152407_323456_745408C1) Date: Thu, 27 Jun 2013 08:23:58 -0500 From: Nishanth Menon MIME-Version: 1.0 To: Luciano Coelho CC: , , , , lkml , , Tony Lindgren , linux-omap , Subject: Re: [PATCH] Documentation: dt: bindings: TI WiLink modules References: <1372149330-24335-1-git-send-email-coelho@ti.com> <51CBC1C8.1040301@gmail.com> <1372322851.18889.53.camel@cumari.coelho.fi> <20130627125131.GA27285@kahuna> <1372337887.8383.12.camel@cumari.coelho.fi> <1372339148.8383.17.camel@cumari.coelho.fi> In-Reply-To: <1372339148.8383.17.camel@cumari.coelho.fi> Content-Type: text/plain; charset="UTF-8"; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 06/27/2013 08:19 AM, Luciano Coelho wrote: > On Thu, 2013-06-27 at 08:15 -0500, Nishanth Menon wrote: >> On Thu, Jun 27, 2013 at 7:58 AM, Luciano Coelho wrote: >>> For the actual DTS files, I could add a wilink.dtsi with enumerations >>> for these values so they could be used in the node definitions. But I'm >>> not sure it's going to be that valuable in the end. >> The way GPIO HIGH was defined might help to provide guidance I think :) > > Where? As far as I can see, the GPIO flags are defined in a bitmap. include/dt-bindings/gpio/gpio.h And corresponding kernel header: include/linux/of_gpio.h just a hint. not saying frequencies were defined in header. for systems that define frequencies - example cpufreq OPPs, clock node usage, we do not use indexing to frequency, instead, that is the responsibility of driver to convert frequency back to required index. git grep frequency Documentation/devicetree/bindings gives you how the precedence looks like. Personally, if given a choice, I'd go with actual frequencies rather than indexes. -- Regards, Nishanth Menon