Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:49048 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663Ab3F0ObC (ORCPT ); Thu, 27 Jun 2013 10:31:02 -0400 Message-ID: <1372343457.8160.10.camel@jlt4.sipsolutions.net> (sfid-20130627_163106_779970_99BBA4BD) Subject: Re: [PATCHv4 02/18] mac80211/rc80211: add chandef to rate initialization From: Johannes Berg To: Simon Wunderlich Cc: linux-wireless@vger.kernel.org, Mathias Kretschmer , Simon Wunderlich Date: Thu, 27 Jun 2013 16:30:57 +0200 In-Reply-To: <20130627142754.GA19965@pandem0nium> References: <1372337064-19254-1-git-send-email-siwu@hrz.tu-chemnitz.de> <1372337064-19254-3-git-send-email-siwu@hrz.tu-chemnitz.de> <1372337940.8160.3.camel@jlt4.sipsolutions.net> <20130627142754.GA19965@pandem0nium> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2013-06-27 at 16:27 +0200, Simon Wunderlich wrote: > On Thu, Jun 27, 2013 at 02:59:00PM +0200, Johannes Berg wrote: > > On Thu, 2013-06-27 at 14:44 +0200, Simon Wunderlich wrote: > > > > > static void ath_rate_init(void *priv, struct ieee80211_supported_band *sband, > > > + struct cfg80211_chan_def *chandef, > > > > I'd argue you can remove the sband pointer now, since the band is known > > from the chandef? > > Not really, these rate algos usually access sband->bitrates, and sband can not be > derived from just the band and these others parameters (at least I miss to see how). sband = hw->wiphy->bands[chandef->chan.band]; no? > > Also, I'm not sure why you'd need this in rate_update, it should be good > > enough in rate_init, no? > > Hm, minstrel_ht seems to be the only use of this function anyway. It calls > minstrel_ht_update_caps() for both rate_init and rate_update, and since both > calls had the same parameter it felt naturally and more easy to change both > the same way. Also this function calls rate_init from minstrel as fallback. Ok, fair enough. johannes