Return-path: Received: from na3sys009aog122.obsmtp.com ([74.125.149.147]:35616 "EHLO na3sys009aog122.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932101Ab3GBFeT convert rfc822-to-8bit (ORCPT ); Tue, 2 Jul 2013 01:34:19 -0400 From: Bing Zhao To: Harvey Yang , "linux-wireless@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" Date: Mon, 1 Jul 2013 22:33:13 -0700 Subject: RE: [PATCH V2 1/1] mwifiex: add tx info to skb when forming mgmt frame Message-ID: <477F20668A386D41ADCC57781B1F70430EA2E061D9@SC-VEXCH1.marvell.com> (sfid-20130702_073422_496641_D5CAF119) References: <1372731526-2979-1-git-send-email-harvey.huawei.yang@gmail.com> In-Reply-To: <1372731526-2979-1-git-send-email-harvey.huawei.yang@gmail.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Harvey, > From: Huawei Yang > > In function 'mwifiex_write_data_complete' it need tx info to find the > mwifiex_private to updates statistics and wake up tx queues. > Or we may trigger tx queues timeout when transmitting lots of mgmt frames. > > Signed-off-by: Huawei Yang > --- > drivers/net/wireless/mwifiex/cfg80211.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/wireless/mwifiex/cfg80211.c > b/drivers/net/wireless/mwifiex/cfg80211.c > index e42b266..b4e2538 100644 > --- a/drivers/net/wireless/mwifiex/cfg80211.c > +++ b/drivers/net/wireless/mwifiex/cfg80211.c > @@ -186,6 +186,7 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy, > struct wireless_dev *wdev, > struct sk_buff *skb; > u16 pkt_len; > const struct ieee80211_mgmt *mgmt; > + struct mwifiex_txinfo *tx_info; > struct mwifiex_private *priv = mwifiex_netdev_get_priv(wdev- > >netdev); > > if (!buf || !len) { > @@ -212,6 +213,10 @@ mwifiex_cfg80211_mgmt_tx(struct wiphy *wiphy, > struct wireless_dev *wdev, > wiphy_err(wiphy, "allocate skb failed for management > frame\n"); > return -ENOMEM; > } > + Here checkpatch.pl script reports whitespace damaged error. I can fix it in my local tree and resend v3 to John after the 3.11 merge window. Thanks, Bing > + tx_info = MWIFIEX_SKB_TXCB(skb); > + tx_info->bss_num = priv->bss_num; > + tx_info->bss_type = priv->bss_type; > > mwifiex_form_mgmt_frame(skb, buf, len); > mwifiex_queue_tx_pkt(priv, skb); > -- > 1.7.10.4