Return-path: Received: from mail-oa0-f52.google.com ([209.85.219.52]:53795 "EHLO mail-oa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754943Ab3GWHuO convert rfc822-to-8bit (ORCPT ); Tue, 23 Jul 2013 03:50:14 -0400 Received: by mail-oa0-f52.google.com with SMTP id g12so10336610oah.25 for ; Tue, 23 Jul 2013 00:50:13 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <51EE3018.4000507@hauke-m.de> References: <1374546675-384-1-git-send-email-linville@tuxdriver.com> <51EE3018.4000507@hauke-m.de> Date: Tue, 23 Jul 2013 09:50:13 +0200 Message-ID: (sfid-20130723_095021_018954_D777D06E) Subject: Re: [PATCH] Make BCMA_HOST_SOC depend on BCM47XX From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= To: Hauke Mehrtens Cc: "John W. Linville" , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: 2013/7/23 Hauke Mehrtens : > On 07/23/2013 04:31 AM, John W. Linville wrote: >> From: "John W. Linville" >> >> Otherwise, 'make allyesconfig' generates this: >> >> CC [M] drivers/net/ethernet/broadcom/bgmac.o >> drivers/net/ethernet/broadcom/bgmac.c:19:27: fatal error: >> bcm47xx_nvram.h: No such file or directory >> compilation terminated. >> make[4]: *** [drivers/net/ethernet/broadcom/bgmac.o] Error 1 >> make[3]: *** [drivers/net/ethernet/broadcom] Error 2 >> make[2]: *** [drivers/net/ethernet] Error 2 >> make[1]: *** [drivers/net] Error 2 >> make: *** [drivers] Error 2 >> >> Signed-off-by: John W. Linville >> --- >> drivers/bcma/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/bcma/Kconfig b/drivers/bcma/Kconfig >> index 7c081b3..a2bdab1 100644 >> --- a/drivers/bcma/Kconfig >> +++ b/drivers/bcma/Kconfig >> @@ -36,7 +36,7 @@ config BCMA_DRIVER_PCI_HOSTMODE >> >> config BCMA_HOST_SOC >> bool "Support for BCMA in a SoC" >> - depends on BCMA >> + depends on BCMA && BCM47XX >> help >> Host interface for a Broadcom AIX bus directly mapped into >> the memory. This only works with the Broadcom SoCs from the >> > I think bgmac should depend on BCM47XX. Yeah, I'm wondering about that. It's bgmac that calls BCM47XX specific functions (nvram). On the other hand it doesn't make much sense to use BCMA_HOST_SOC on anything else than BCM47XX, does it? -- Rafał