Return-path: Received: from mail-lb0-f181.google.com ([209.85.217.181]:52650 "EHLO mail-lb0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282Ab3GKNrI (ORCPT ); Thu, 11 Jul 2013 09:47:08 -0400 Received: by mail-lb0-f181.google.com with SMTP id w10so6662165lbi.40 for ; Thu, 11 Jul 2013 06:47:05 -0700 (PDT) Message-ID: <51DEB757.6070202@cogentembedded.com> (sfid-20130711_154714_378323_3C3529EA) Date: Thu, 11 Jul 2013 17:47:03 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Oliver Neukum CC: Ming Lei , Greg Kroah-Hartman , linux-usb@vger.kernel.org, Alan Stern , linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Juergen Stuber Subject: Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup References: <1373533573-12272-1-git-send-email-ming.lei@canonical.com> <1373533573-12272-9-git-send-email-ming.lei@canonical.com> <51DEA289.5050509@cogentembedded.com> <3187374.nPY1jDDWKm@linux-5eaq.site> In-Reply-To: <3187374.nPY1jDDWKm@linux-5eaq.site> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hello. On 11-07-2013 16:36, Oliver Neukum wrote: >> I don't think this patch passes checkpatch.pl. > This series is a mechanical replacement in dozens of drivers. That mechanicity shows too much in some patches. > We cannot demand nice formatting. If you want to do something > productive, check the locking in the driver. I'm not paid for it and don't have time to do it for free. > Regards > Oliver WBR, Sergei