Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:53188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730Ab3G1FUF (ORCPT ); Sun, 28 Jul 2013 01:20:05 -0400 Date: Sat, 27 Jul 2013 22:20:03 -0700 (PDT) Message-Id: <20130727.222003.1753039618642833143.davem@davemloft.net> (sfid-20130728_072016_166996_0B53E932) To: pshelar@nicira.com Cc: sgruszka@redhat.com, linux-wireless@vger.kernel.org, linville@tuxdriver.com, netdev@vger.kernel.org, tgraf@suug.ch, shemminger@vyatta.com, rjones@redhat.com, marcel@holtmann.org, jlayton@redhat.com Subject: Re: [PATCH 3.11] genetlink: release cb_lock before requesting additional module From: David Miller In-Reply-To: References: <20130725105116.043a6b9c@corrin.poochiereds.net> <20130726090010.GA1756@redhat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Pravin Shelar Date: Fri, 26 Jul 2013 10:08:25 -0700 > On Fri, Jul 26, 2013 at 2:00 AM, Stanislaw Gruszka wrote: >> Requesting external module with cb_lock taken can result in >> the deadlock like showed below: ... >> Problem start to happen after adding net-pf-16-proto-16-family-nl80211 >> alias name to cfg80211 module by below commit (though that commit >> itself is perfectly fine): >> >> commit fb4e156886ce6e8309e912d8b370d192330d19d3 >> Author: Marcel Holtmann >> Date: Sun Apr 28 16:22:06 2013 -0700 >> >> nl80211: Add generic netlink module alias for cfg80211/nl80211 >> >> Reported-and-tested-by: Jeff Layton >> Reported-by: Richard W.M. Jones >> Signed-off-by: Stanislaw Gruszka ... > This is genl issue and it was introduced by commit def3117493eafd > (genl: Allow concurrent genl callbacks.). > > Reviewed-by: Pravin B Shelar Applied and queued up for -stable, thanks.