Return-path: Received: from mail.openrapids.net ([64.15.138.104]:41748 "EHLO blackscsi.openrapids.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965185Ab3GLRId (ORCPT ); Fri, 12 Jul 2013 13:08:33 -0400 Date: Fri, 12 Jul 2013 13:08:28 -0400 From: Mathieu Desnoyers To: Sarah Sharp Cc: Kalle Valo , Johannes Berg , Xenia Ragiadakou , OPW Kernel Interns List , linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, Steven Rostedt , linux-trace-users@vger.kernel.org, lttng-dev@lists.lttng.org Subject: Re: Help adding trace events to xHCI Message-ID: <20130712170827.GA18819@Krystal> (sfid-20130712_190840_171276_964DE704) References: <51DB0257.1010709@gmail.com> <20130711162002.GA5240@xanatos> <1373562533.8201.33.camel@jlt4.sipsolutions.net> <20130711190035.GD5240@xanatos> <87y59c4d60.fsf@kamboji.qca.qualcomm.com> <20130712164104.GA15531@xanatos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20130712164104.GA15531@xanatos> Sender: linux-wireless-owner@vger.kernel.org List-ID: * Sarah Sharp (sarah.a.sharp@linux.intel.com) wrote: > On Fri, Jul 12, 2013 at 07:25:59AM +0300, Kalle Valo wrote: > > Sarah Sharp writes: > > > > > My initial list of specific trace points was something like: > > > > > > 1. xHCI host initialization and shutdown > > > > > > 2. xHCI memory allocation (dynamic ring resizing, structure alloc, etc) > > > > > > 3. A few individual xHCI host controller command tracepoints: > > > * status only for all completed commands > > > * Address Device command status and output > > > * Configure Endpoint and Evaluate Context output > > > * individual trace points for other xHCI commands > > > > > > 4. Tracepoints for all USB transfer types: > > > * Control TX output (only for non-successful transfers) > > > * Bulk TX > > > * Interrupt TX > > > * Isoc TX > > > > > > 5. URB cancellation > > > > > > And probably more. Basically, I want to be able to control what gets > > > printed, based on where I think the xHCI bug might be. Does that sound > > > reasonable? > > > > Instead of individual trace points for command I would recommend to > > consider just pushing the whole command buffer to the trace point and > > parse the command in trace-cmd plugin in user space. Kernel code would > > be simpler that way. > > Thanks for the suggestion. I'm not familiar with all the userspace > tools for trace events, so I didn't know about the command parser. Is > there documentation or a list of resources for all the userspace trace > event plugins? If so, can you give us a pointer to it? (CCing lttng-dev) You might want to try out LTTng-UST. It provides TRACEPOINT_EVENT() and tracepoint() for user-space instrumentation. See: - https://lttng.org/files/doc/man-pages/man3/lttng-ust.3.html - http://lttng.org Thanks, Mathieu > > Sarah Sharp > -- > To unsubscribe from this list: send the line "unsubscribe linux-trace-users" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com