Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:42187 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255Ab3GKMmw (ORCPT ); Thu, 11 Jul 2013 08:42:52 -0400 MIME-Version: 1.0 In-Reply-To: <51DEA289.5050509@cogentembedded.com> References: <1373533573-12272-1-git-send-email-ming.lei@canonical.com> <1373533573-12272-9-git-send-email-ming.lei@canonical.com> <51DEA289.5050509@cogentembedded.com> Date: Thu, 11 Jul 2013 20:42:49 +0800 Message-ID: (sfid-20130711_144300_697720_B4639287) Subject: Re: [PATCH 08/50] USB: legousbtower: spin_lock in complete() cleanup From: Ming Lei To: Sergei Shtylyov Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Oliver Neukum , Alan Stern , linux-input@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-media@vger.kernel.org, alsa-devel@alsa-project.org, Juergen Stuber Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jul 11, 2013 at 8:18 PM, Sergei Shtylyov wrote: > Hello. > > > On 11-07-2013 13:05, Ming Lei wrote: > >> Complete() will be run with interrupt enabled, so change to >> spin_lock_irqsave(). > > >> Cc: Juergen Stuber >> Signed-off-by: Ming Lei >> --- >> drivers/usb/misc/legousbtower.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > >> diff --git a/drivers/usb/misc/legousbtower.c >> b/drivers/usb/misc/legousbtower.c >> index 8089479..4044989 100644 >> --- a/drivers/usb/misc/legousbtower.c >> +++ b/drivers/usb/misc/legousbtower.c >> @@ -771,6 +771,7 @@ static void tower_interrupt_in_callback (struct urb >> *urb) >> struct lego_usb_tower *dev = urb->context; >> int status = urb->status; >> int retval; >> + unsigned long flags; >> >> dbg(4, "%s: enter, status %d", __func__, status); >> >> @@ -788,7 +789,7 @@ static void tower_interrupt_in_callback (struct urb >> *urb) >> } >> >> if (urb->actual_length > 0) { >> - spin_lock (&dev->read_buffer_lock); >> + spin_lock_irqsave (&dev->read_buffer_lock, flags); >> if (dev->read_buffer_length + urb->actual_length < >> read_buffer_size) { >> memcpy (dev->read_buffer + >> dev->read_buffer_length, >> dev->interrupt_in_buffer, >> @@ -799,7 +800,7 @@ static void tower_interrupt_in_callback (struct urb >> *urb) >> } else { >> printk(KERN_WARNING "%s: read_buffer overflow, %d >> bytes dropped", __func__, urb->actual_length); >> } >> - spin_unlock (&dev->read_buffer_lock); >> + spin_unlock_irqrestore (&dev->read_buffer_lock, flags); >> } > > > I don't think this patch passes checkpatch.pl. No errors reported from checkpatch.pl, only warnings which isn't introduced by this patch. Thanks, -- Ming Lei