Date: Mon, 12 Aug 2013 17:26:03 -0700
From: Greg KH <gregkh@linuxfoundation.org>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6656: rxtx.h always pack
 BEACON_BUFFER/TX_BUFFER
Message-ID: <20130813002603.GB32683@kroah.com> (sfid-20130813_022611_965028_15835DF2)
References: <1375733094.7004.23.camel@canaries64>
 <20130812215959.GA1473@kroah.com>
 <1376348835.12399.15.camel@canaries32-MCP7A>
 <20130812230936.GA31302@kroah.com>
 <1376350516.13046.6.camel@canaries32-MCP7A>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
In-Reply-To: <1376350516.13046.6.camel@canaries32-MCP7A>
Sender: linux-wireless-owner@vger.kernel.org

On Tue, Aug 13, 2013 at 12:35:16AM +0100, Malcolm Priestley wrote:
> On Mon, 2013-08-12 at 16:09 -0700, Greg KH wrote:
> > On Tue, Aug 13, 2013 at 12:07:15AM +0100, Malcolm Priestley wrote:
> > > On Mon, 2013-08-12 at 14:59 -0700, Greg KH wrote:
> > > > On Mon, Aug 05, 2013 at 09:04:54PM +0100, Malcolm Priestley wrote:
> > > > > All structure members of BEACON_BUFFER/TX_BUFFER should be packed.
> > > > 
> > > > Why?
> > > 
> > > Only the first 4 members of these structures are live.
> > > 
> > > The forth member is referenced at run-time by packed structures.
> > > typedef struct tagSTxBufHead
> > > typedef struct tagSTxShortBufHead
> > > in desc.h
> > > 
> > > If these structures are not packed the alignment of these members
> > > will be wrong.
> > 
> > Then say all of this in the patch please :)
> > 
> > > > 
> > > > What happens if they are not?
> > > The driver does not work.
> > 
> > How is it working today without this change?
> Well for *me* it works.
> 
> It appears the structure is packed anyway.
> 
> But is this guaranteed?
> 
> Anyway, do you want me to resend the patch.
> 

Yes, please do, with this added information, and all other patches from
you that I did not apply, due to me not accepting this one.

thanks,

greg k-h