Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:45380 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753028Ab3H0NIH (ORCPT ); Tue, 27 Aug 2013 09:08:07 -0400 Date: Tue, 27 Aug 2013 09:07:47 -0400 From: Neil Horman To: Joe Perches Cc: netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, b43-dev@lists.infradead.org Subject: Re: [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent Message-ID: <20130827130747.GA7619@hmsreliant.think-freely.org> (sfid-20130827_150829_139285_A1B23043) References: <1377582323.2658.10.camel@joe-AO722> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1377582323.2658.10.camel@joe-AO722> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, Aug 26, 2013 at 10:45:23PM -0700, Joe Perches wrote: > __GFP_ZERO is an uncommon flag and perhaps is better > not used. static inline dma_zalloc_coherent exists > so convert the uses of dma_alloc_coherent with __GFP_ZERO > to the more common kernel style with zalloc. > > Remove memset from the static inline dma_zalloc_coherent > and add just one use of __GFP_ZERO instead. > > Trivially reduces the size of the existing uses of > dma_zalloc_coherent. > > Realign arguments as appropriate. > > Signed-off-by: Joe Perches Acked-by: Neil Horman