Return-path: Received: from mail-bk0-f44.google.com ([209.85.214.44]:36522 "EHLO mail-bk0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755217Ab3HFJMM (ORCPT ); Tue, 6 Aug 2013 05:12:12 -0400 Received: by mail-bk0-f44.google.com with SMTP id mz10so53245bkb.17 for ; Tue, 06 Aug 2013 02:12:11 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5200B1BD.7030307@gmail.com> References: <325b19bb936d7ebae11edad86aac8f0931e8abd9.1375719828.git.luto@amacapital.net> <5200B1BD.7030307@gmail.com> From: Tom Gundersen Date: Tue, 6 Aug 2013 11:11:51 +0200 Message-ID: (sfid-20130806_111228_770562_A3E122C6) Subject: Re: [systemd-devel] [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it To: Maarten Lankhorst Cc: Andy Lutomirski , systemd-devel@lists.freedesktop.org, linux-hotplug@vger.kernel.org, Linux Wireless List , linux-kernel@vger.kernel.org, Intel Linux Wireless , Kay Sievers , Johannes Berg Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst wrote: > Op 05-08-13 18:29, Andy Lutomirski schreef: >> The systemd commit below can delay firmware loading by multiple >> minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one >> noticed that the systemd-udev change would break new kernels as well >> as old kernels. >> >> Since the kernel apparently can't count on reasonable userspace >> support, turn this thing off by default. >> >> commit a3bd8447be4ea2ce230eb8ae0e815c04d85fa15a >> Author: Tom Gundersen >> Date: Mon Mar 18 15:12:18 2013 +0100 >> >> udev: make firmware loading optional and disable by default >> >> Distros that whish to support old kernels should set >> --with-firmware-dirs="/usr/lib/firmware/updates:/usr/lib/firmware" >> to retain the old behaviour. >> > methinks this patch should be reverted then, Well, all the code is still there, so it can be enabled if anyone wants it. > or a stub should be added to udev to always fail firmware loading so timeouts don't occur. I think the only use (if any) of a userspace firmware loader would be for anyone who wants a custom one (i.e., not udev), so we shouldn't just fail the loading from udev unconditionally. How about we just improve the udev documentation a bit, similar to Andy's kernel patch? Cheers, Tom