Return-path: Received: from perches-mx.perches.com ([206.117.179.246]:38930 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754439Ab3HEDdi (ORCPT ); Sun, 4 Aug 2013 23:33:38 -0400 Message-ID: <1375673616.3133.23.camel@joe-AO722> (sfid-20130805_053403_373969_767BD2AC) Subject: Re: [PATCH] hostap: do not return positive number on failure path in prism2_open() From: Joe Perches To: Alexey Khoroshilov Cc: Jouni Malinen , "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Date: Sun, 04 Aug 2013 20:33:36 -0700 In-Reply-To: <1375672708-3017-1-git-send-email-khoroshilov@ispras.ru> References: <1375672708-3017-1-git-send-email-khoroshilov@ispras.ru> Content-Type: text/plain; charset="ISO-8859-1" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2013-08-05 at 07:18 +0400, Alexey Khoroshilov wrote: > prism2_open() as an .ndo_open handler should not return positive numbers > in case of failure, but it does return 1 in a couple of places. > > Found by Linux Driver Verification project (linuxtesting.org). How? http://linuxtesting.org/project/ldv http://linuxtesting.org/results/ldv Shows defects and patches to fix them, but not any script used to find it.