Return-path: Received: from s3.sipsolutions.net ([144.76.43.152]:56480 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168Ab3HTVEB (ORCPT ); Tue, 20 Aug 2013 17:04:01 -0400 Message-ID: <1377032637.13829.42.camel@jlt4.sipsolutions.net> (sfid-20130820_230407_217988_34BA0DD8) Subject: Re: [PATCH 11/16] wcn36xx: Add txrx.c From: Johannes Berg To: Eugene Krasnikov Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org Date: Tue, 20 Aug 2013 23:03:57 +0200 In-Reply-To: <1377020479-16935-12-git-send-email-k.eugene.e@gmail.com> (sfid-20130820_194157_436842_7EF6BDFF) References: <1377020479-16935-1-git-send-email-k.eugene.e@gmail.com> <1377020479-16935-12-git-send-email-k.eugene.e@gmail.com> (sfid-20130820_194157_436842_7EF6BDFF) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2013-08-20 at 19:41 +0200, Eugene Krasnikov wrote: > +int wcn36xx_start_tx(struct wcn36xx *wcn, > + struct wcn36xx_sta *sta_priv, > + struct sk_buff *skb) err ... this can return errors that you never handle, probably gets you leaks that way? johannes