Return-path: Received: from mga03.intel.com ([143.182.124.21]:24379 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751819Ab3HLITT convert rfc822-to-8bit (ORCPT ); Mon, 12 Aug 2013 04:19:19 -0400 From: "Berg, Johannes" To: Djalal Harouni , "Grumbach, Emmanuel" , Intel Linux Wireless , "John W. Linville" , "linux-kernel@vger.kernel.org" , "linux-wireless@vger.kernel.org" Subject: RE: [PATCH] iwlwifi: mvm: make debugfs write() operations write up to count bytes Date: Mon, 12 Aug 2013 08:19:12 +0000 Message-ID: <1DC40B07CD6EC041A66726C271A73AE61AA5E38C@IRSMSX102.ger.corp.intel.com> (sfid-20130812_101937_584687_F735D50C) References: <1376267972-5636-1-git-send-email-tixxdz@opendz.org> In-Reply-To: <1376267972-5636-1-git-send-email-tixxdz@opendz.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > Some debugfs write() operations of the MVM Firmware will ignore the count > argument, and will copy more bytes than what was specified. > Fix this by getting the right count of bytes. > > This will also honor restrictions put on the number of bytes to write. That makes some sense. > To be consitant this patch also switches the initializer from 'char buf[x] = {}' to > the explicit memset() as it is done in other places of the same file. I'd rather this (a) be done in a separate patch, and (b) the other way around, switch everything to C99. > Cc: stable@vger.kernel.org That doesn't really make sense for the debugfs interface. > + memset(buf, 0, sizeof(buf)); > + if (count > sizeof(buf) - 1) > + count = sizeof(buf) - 1; Why -1? And why not use min()/min_t()? johannes -- Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052