Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:41360 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941Ab3H3CJ2 (ORCPT ); Thu, 29 Aug 2013 22:09:28 -0400 Date: Thu, 29 Aug 2013 22:09:26 -0400 (EDT) Message-Id: <20130829.220926.226210132086755040.davem@davemloft.net> (sfid-20130830_040948_391858_3E239DFF) To: joe@perches.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, users@rt2x00.serialmonkey.com Subject: Re: [PATCH net-next] drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent From: David Miller In-Reply-To: <1377582323.2658.10.camel@joe-AO722> References: <1377582323.2658.10.camel@joe-AO722> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Joe Perches Date: Mon, 26 Aug 2013 22:45:23 -0700 > __GFP_ZERO is an uncommon flag and perhaps is better > not used. static inline dma_zalloc_coherent exists > so convert the uses of dma_alloc_coherent with __GFP_ZERO > to the more common kernel style with zalloc. > > Remove memset from the static inline dma_zalloc_coherent > and add just one use of __GFP_ZERO instead. > > Trivially reduces the size of the existing uses of > dma_zalloc_coherent. > > Realign arguments as appropriate. > > Signed-off-by: Joe Perches Applied, thanks a lot Joe.