Return-path: Received: from mail-ve0-f179.google.com ([209.85.128.179]:53134 "EHLO mail-ve0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755917Ab3HFQIu (ORCPT ); Tue, 6 Aug 2013 12:08:50 -0400 Received: by mail-ve0-f179.google.com with SMTP id c13so621895vea.38 for ; Tue, 06 Aug 2013 09:08:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <325b19bb936d7ebae11edad86aac8f0931e8abd9.1375719828.git.luto@amacapital.net> <5200B1BD.7030307@gmail.com> From: Andy Lutomirski Date: Tue, 6 Aug 2013 09:08:29 -0700 Message-ID: (sfid-20130806_180907_653470_E46B9008) Subject: Re: [systemd-devel] [PATCH] Change CONFIG_FW_LOADER_USER_HELPER to default n and don't select it To: Tom Gundersen Cc: Maarten Lankhorst , systemd-devel@lists.freedesktop.org, linux-hotplug@vger.kernel.org, Linux Wireless List , linux-kernel@vger.kernel.org, Intel Linux Wireless , Kay Sievers , Johannes Berg Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 6, 2013 at 2:17 AM, Tom Gundersen wrote: > On Tue, Aug 6, 2013 at 11:11 AM, Tom Gundersen wrote: >> On Tue, Aug 6, 2013 at 10:20 AM, Maarten Lankhorst >> wrote: >>> Op 05-08-13 18:29, Andy Lutomirski schreef: >>>> The systemd commit below can delay firmware loading by multiple >>>> minutes if CONFIG_FW_LOADER_USER_HELPER=y. Unfortunately no one >>>> noticed that the systemd-udev change would break new kernels as well >>>> as old kernels. >>>> >>>> Since the kernel apparently can't count on reasonable userspace >>>> support, turn this thing off by default. >>>> >>>> commit a3bd8447be4ea2ce230eb8ae0e815c04d85fa15a >>>> Author: Tom Gundersen >>>> Date: Mon Mar 18 15:12:18 2013 +0100 >>>> >>>> udev: make firmware loading optional and disable by default >>>> >>>> Distros that whish to support old kernels should set >>>> --with-firmware-dirs="/usr/lib/firmware/updates:/usr/lib/firmware" >>>> to retain the old behaviour. >>>> >>> methinks this patch should be reverted then, >> >> Well, all the code is still there, so it can be enabled if anyone wants it. >> >>> or a stub should be added to udev to always fail firmware loading so timeouts don't occur. >> >> I think the only use (if any) of a userspace firmware loader would be >> for anyone who wants a custom one (i.e., not udev), so we shouldn't >> just fail the loading from udev unconditionally. >> >> How about we just improve the udev documentation a bit, similar to >> Andy's kernel patch? > > Sorry, I should first have checked. We already document this in the README: > >> Userspace firmware loading is deprecated, will go away, and >> sometimes causes problems: >> CONFIG_FW_LOADER_USER_HELPER=n TBH, the udev README is the last thing I'm going to check to figure out why I don't have wifi for a couple minutes after boot. Also, the message is missing the point. It's not that it's deprecated and sometimes causes problems -- it's that udev *changed behavior* and breaks your system if you have CONFIG_FW_LOADER_USER_HELPER=y. If udev logged something (for a couple of years), that would be a different story. --Andy