Return-path: Received: from mail-qc0-f172.google.com ([209.85.216.172]:36781 "EHLO mail-qc0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003Ab3HDOYp (ORCPT ); Sun, 4 Aug 2013 10:24:45 -0400 Received: by mail-qc0-f172.google.com with SMTP id a1so1227324qcx.17 for ; Sun, 04 Aug 2013 07:24:44 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130731120848.GA31732@redhat.com> References: <20130603141804.GA2146@redhat.com> <20130611161924.GB1696@redhat.com> <20130614131829.GA5125@redhat.com> <20130625142514.GA1938@redhat.com> <20130716102743.GA8321@redhat.com> <20130731120848.GA31732@redhat.com> From: Pedro Francisco Date: Sun, 4 Aug 2013 15:24:24 +0100 Message-ID: (sfid-20130804_162501_615587_2AE86F17) Subject: Re: Power saving features for iwl4965 To: Stanislaw Gruszka Cc: Tino Keitel , ML linux-wireless Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jul 31, 2013 at 1:08 PM, Stanislaw Gruszka wrote: > On Wed, Jul 17, 2013 at 12:48:30PM +0100, Pedro Francisco wrote: >> On Tue, Jul 16, 2013 at 11:27 AM, Stanislaw Gruszka wrote: >> >> I seem only to be able to trigger it with disable_hw_scan=0, I need >> >> further testing with disable_hw_scan=1 (I use disable_hw_scan=0 >> >> because it prevents me from getting disconnected from eduroam Cisco >> >> APs -- haven't tested disable_hw_scan=0 since the VOIP-friendly SW >> >> scanning patch, however). >> >> >> >> Do you want the log anyway? (modprobe iwl3945 debug=0x47ffffff >> >> disable_hw_scan=0 and runtime PCI powersave also enabled -- I don't >> >> know if it matters). >> > >> > As this is not causing troubles with default disable_hw_scan option, >> > I'll post that patch. >> >> My mistake, I can trigger error conditions _independently_ of >> disable_hw_scan option being enabled or disabled, as long as powersave >> is enabled. >> >> I'll send you a private email with the logs. > > I think I found bug which couse this firmware crash. We have only 5 > queues so updating write_ptr for txq[5] can cause random value write > to HBUS_TARG_WRPTR register. I also added spin_lock to do not abuse > writes we do in tx skb. > > Please test attached patch (with powersave on :-) Still not working :( I tested for two nights, first one was fine, second was not (the only difference was I had kernel parameter `slub_debug` on the second night, but my guess it shouldn't affect anything?). Snippet of log follows, full logs I'll send privately (beware, unzipped it's 423MB). Anyway, any idea what is the value 0xa5a5a5a2 ? It's always the same value which makes the reloaded firmware to fail... And in other firmware failures around the Web, both iwlegacy and iwlwifi. Aug 4 09:23:58 s2 kernel: [32309.937084] iwl3945 0000:02:00.0: Queue 4 stuck for 2004 ms. Aug 4 09:23:58 s2 kernel: [32309.937106] iwl3945 0000:02:00.0: On demand firmware reload Aug 4 09:23:58 s2 kernel: [32309.937128] ieee80211 phy1: U __il3945_down iwl3945 is going down Aug 4 09:23:58 s2 kernel: [32309.937137] ieee80211 phy1: U il_scan_cancel_timeout Scan cancel timeout Aug 4 09:23:58 s2 kernel: [32309.937143] ieee80211 phy1: U il_do_scan_abort Not performing scan to abort Aug 4 09:23:58 s2 kernel: [32309.937149] ieee80211 phy1: U il_clear_ucode_stations Clearing ucode stations in driver Aug 4 09:23:58 s2 kernel: [32309.937155] ieee80211 phy1: U il_clear_ucode_stations Clearing ucode active for station 0 Aug 4 09:23:58 s2 kernel: [32309.937162] ieee80211 phy1: U il_clear_ucode_stations Clearing ucode active for station 24 Aug 4 09:23:58 s2 kernel: [32309.938116] ieee80211 phy1: U _il_apm_stop Stop card, put in low power state Aug 4 09:23:58 s2 kernel: [32309.938116] iwl3945 0000:02:00.0: Master Disable Timed Out, 100 usec Aug 4 09:23:58 s2 kernel: [32309.938116] ieee80211 phy1: U _il_apm_stop_master stop master Aug 4 09:23:58 s2 kernel: [32309.954705] ieee80211 phy1: U il3945_clear_free_frames 0 frames on pre-allocated heap on clear. Aug 4 09:23:58 s2 kernel: [32309.954740] ieee80211 phy1: Hardware restart was requested Aug 4 09:23:58 s2 kernel: [32309.954757] ieee80211 phy1: U il3945_mac_start enter Aug 4 09:23:58 s2 kernel: [32309.954763] ieee80211 phy1: U il_prep_station Add STA to driver ID 24: ff:ff:ff:ff:ff:ff Aug 4 09:23:58 s2 kernel: [32309.954774] ieee80211 phy1: U il_apm_init Init card's basic functions Aug 4 09:23:58 s2 kernel: [32309.955111] ieee80211 phy1: U il3945_nic_config HW Revision ID = 0x2 Aug 4 09:23:58 s2 kernel: [32309.955117] ieee80211 phy1: U il3945_nic_config 3945 RADIO-MM type Aug 4 09:23:58 s2 kernel: [32309.955127] ieee80211 phy1: U il3945_nic_config SKU OP mode is basic Aug 4 09:23:58 s2 kernel: [32309.955131] ieee80211 phy1: U il3945_nic_config 3945ABG revision is 0xF1 Aug 4 09:23:58 s2 kernel: [32309.955140] ieee80211 phy1: U il3945_nic_config Card M type B version is 0x3 Aug 4 09:23:58 s2 kernel: [32309.955150] ieee80211 phy1: U il3945_nic_config SW RF KILL supported in EEPROM. Aug 4 09:23:58 s2 kernel: [32309.955153] ieee80211 phy1: U il3945_nic_config HW RF KILL supported in EEPROM. Aug 4 09:23:58 s2 kernel: [32309.974318] ieee80211 phy1: U il3945_load_bsm Begin load bsm Aug 4 09:23:58 s2 kernel: [32310.018857] ieee80211 phy1: U il3945_verify_bsm Begin verify bsm Aug 4 09:23:58 s2 kernel: [32310.020628] iwl3945 0000:02:00.0: BSM uCode verification failed at addr 0x00003800+0 (of 900), is 0xa5a5a5a2, s/b 0xf802020 Aug 4 09:23:58 s2 kernel: [32310.020632] iwl3945 0000:02:00.0: Unable to set up bootstrap uCode: -5 Aug 4 09:23:58 s2 kernel: [32310.020636] ieee80211 phy1: U il3945_load_bsm Begin load bsm Aug 4 09:23:58 s2 kernel: [32310.041691] hrtimer: interrupt took 3021833 ns Aug 4 09:23:58 s2 kernel: [32310.065681] ieee80211 phy1: U il3945_verify_bsm Begin verify bsm Aug 4 09:23:58 s2 kernel: [32310.067345] iwl3945 0000:02:00.0: BSM uCode verification failed at addr 0x00003800+0 (of 900), is 0xa5a5a5a2, s/b 0xf802020 -- Pedro